Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix trusted types violation in packages/auth/src/platform_browser/index.ts#9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
KJ202 wants to merge1 commit intofirebase:main
base:main
Choose a base branch
Loading
fromKJ202:finalPatch

Conversation

@KJ202
Copy link

@KJ202KJ202 commentedDec 1, 2025•
edited
Loading

This change addresses a Trusted Types violation intheloadJS function. The violation occurs because a URL constructed from a string is used to set thesrc attribute of a script element, which is a potential DOM XSS vulnerability.

The patch resolves this issue by usingsafevalues.safeUrl to create aSafeUrl object from the URL string. This sanitized URL is then used with thesafevalues.dom.setSrc function to safely set thesrc attribute of the script element. This ensures that only sanitized, trusted URLs can be loaded, thus mitigating the risk of DOM XSS attacks.

This change is purely for security and has no functional impact.

Test: Verified that all existing tests pass after the change.

@changeset-bot
Copy link

changeset-botbot commentedDec 1, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:1d9f402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KJ202KJ202 changed the titleFinal patchFix trusted types violation in packages/auth/src/platform_browser/index.tsDec 2, 2025
@KJ202KJ202 marked this pull request as ready for reviewDecember 2, 2025 05:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lisajianlisajianAwaiting requested review from lisajianlisajian is a code owner

@Xiaoshouzi-ghXiaoshouzi-ghAwaiting requested review from Xiaoshouzi-ghXiaoshouzi-gh is a code owner

@sam-gcsam-gcAwaiting requested review from sam-gcsam-gc is a code owner

@pashankapashankaAwaiting requested review from pashankapashanka is a code owner

@mansisampatmansisampatAwaiting requested review from mansisampatmansisampat is a code owner

@NhienLamNhienLamAwaiting requested review from NhienLamNhienLam is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KJ202
[8]ページ先頭
©2009-2025 Movatter.jp