Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

build: new internal builds for google3#9139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
hsubox76 wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromch-google3
Draft

Conversation

hsubox76
Copy link
Contributor

Create new builds that are only triggered during the internal google3 build, for google3 consumers:

  • firebase.js - includes every product
  • firebase-analytics-rc.js - includes those two products - special request by an internal team

It also doesn't look like we need to do the convoluted rollup config swap that we do in the google3 import script (internal link:https://source.corp.google.com/piper///depot/google3/third_party/javascript/firebase/updateThirdParty.sh;rcl=666835113;l=91) when we have a special build:internal script that can simply call the other config, so I changed that.

I assume we need to roll up new typings for each of the new bundles, so I added a step to generate those.

An unfortunate complication is that simply exporting* from each package leads to name collisions so every module needs to be namespaced with the product name, so thatinitializeApp must be referred to asapp.initializeApp for example. This is really going backwards toward the old compat packages but the g3 ecosystem doesn't really give us much choice.

Also I noticed the rollup-internal.config.js builds every file that the main one does, including the non-cdn ones (such as the individual product entry points under firebase/) which doesn't seem necessary as they're not included in any BUILD target in google3, so I removed those. Will see if this causes a problem.

I will leave this as a branch and a draft that can be imported into google3 and iterated on based on whether it works there.

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 2, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:91c709b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commentedJul 2, 2025•
edited
Loading

Size Report1

Affected Products

  • @firebase/firestore

    TypeBase (8072572)Merge (c65c72d)Diff
    browser395 kB395 kB-356 B (-0.1%)
    main616 kB615 kB-555 B (-0.1%)
    module395 kB395 kB-356 B (-0.1%)
    react-native395 kB395 kB-357 B (-0.1%)

  • @firebase/firestore-lite

    TypeBase (8072572)Merge (c65c72d)Diff
    browser117 kB116 kB-347 B (-0.3%)
    main160 kB159 kB-608 B (-0.4%)
    module117 kB116 kB-347 B (-0.3%)
    react-native117 kB116 kB-349 B (-0.3%)

  • bundle

    15 size changes

    TypeBase (8072572)Merge (c65c72d)Diff
    firestore (CSI Auto Indexing Disable and Delete)291 kB290 kB-238 B (-0.1%)
    firestore (CSI Auto Indexing Enable)291 kB290 kB-238 B (-0.1%)
    firestore (Persistence)322 kB322 kB-201 B (-0.1%)
    firestore (Query Cursors)260 kB260 kB-201 B (-0.1%)
    firestore (Query)258 kB258 kB-201 B (-0.1%)
    firestore (Read data once)248 kB247 kB-201 B (-0.1%)
    firestore (Read Write w Persistence)342 kB342 kB-201 B (-0.1%)
    firestore (Realtime updates)248 kB248 kB-201 B (-0.1%)
    firestore (Transaction)227 kB227 kB-238 B (-0.1%)
    firestore (Write data)228 kB228 kB-238 B (-0.1%)
    firestore-lite (Query Cursors)111 kB111 kB-212 B (-0.2%)
    firestore-lite (Query)107 kB107 kB-212 B (-0.2%)
    firestore-lite (Read data once)82.9 kB82.7 kB-212 B (-0.3%)
    firestore-lite (Transaction)108 kB108 kB-212 B (-0.2%)
    firestore-lite (Write data)92.4 kB92.1 kB-212 B (-0.2%)

  • firebase

    TypeBase (8072572)Merge (c65c72d)Diff
    firebase-compat.js807 kB807 kB-174 B (-0.0%)
    firebase-firestore-compat.js351 kB351 kB-174 B (-0.0%)
    firebase-firestore-lite.js140 kB139 kB-351 B (-0.3%)
    firebase-firestore.js459 kB458 kB-366 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pvVV5MMnnY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commentedJul 2, 2025•
edited
Loading

Size Analysis Report1

This report is too large (864,920 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q4k4uN7rP3.html

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hsubox76@google-oss-bot
[8]ページ先頭
©2009-2025 Movatter.jp