- Notifications
You must be signed in to change notification settings - Fork342
Update support for type hints#923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello@ViktorSky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This is an impressive and comprehensive effort to add type annotations across thefirebase_admin codebase. The changes significantly improve the developer experience by enabling static analysis, leading to better code quality and maintainability. The use of modern typing features likeTypeVar,Generic,Literal, andoverload is excellent. The refactoring ofcreate_user andupdate_user to use explicit keyword arguments instead of**kwargs is a particularly noteworthy improvement for API clarity and safety. I have one minor suggestion to make theHttpClient more robust after being closed.
Uh oh!
There was an error while loading.Please reload this page.
gemini-code-assistCo-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This pull request introducescomprehensive type annotations to the
firebase_admincodebase usingPEP 484 standards. All changes have been validated withPyright instrict mode to enforce consistency and catch potential type errors early.Goals
Tools
Configuration Additions
pyrightconfig.json: config file created to declare strict-mode settings.