Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(auth): UpdateActionCodeSettings to supportlink_domain and deprecatedynamic_link_domain#884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@huwmartin
Copy link
Contributor

@huwmartinhuwmartin commentedJun 3, 2025•
edited
Loading

Discussion

Firebase Dynamic Links will stop working August 25th 2025.

Migration instructions indicate that to use a custom domain one should update usage ofActionCodeSettings to uselinkDomain, see also in theFirebase Admin docs.

We currently depend upongenerate_sign_in_with_email_link to generate email links,firebase-admin-python hasn't been updated withlink_domain and currently only supportsdynamic_link_domain,firebase-admin-node has been updated with support forlinkDomain so I assume this should be officially supported, please let me know if this is not the case.

See#883.

This PR updatesActionCodeSettings to acceptlink_domain and updatesencode_action_code_settings to handlelink_domain when constructing request payload. I have also added definition for newInvalidHostingLinkDomainError error.

errkk and matt-newhall reacted with heart emoji
@huwmartin
Copy link
ContributorAuthor

@lahirumaramba@pashanka see here re:#883. In my org we're currently relying on this via a fork and would be great to get into main release.

Copy link

@Xiaoshouzi-ghXiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for putting this together!

Copy link

@Xiaoshouzi-ghXiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for putting this together!

Copy link

@Xiaoshouzi-ghXiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

huwmartin reacted with thumbs up emoji
@huwmartinhuwmartinforce-pushed theaction-code-settings-link-domain branch from1d9d933 todfce7c1CompareJuly 7, 2025 17:33
@lahirumarambalahirumaramba self-assigned thisJul 8, 2025
@jonathanedeyjonathanedey self-requested a reviewJuly 14, 2025 14:14
Copy link
Contributor

@jonathanedeyjonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@huwmartin for putting this together! Overall LGTM with one minor change below.

@jonathanedeyjonathanedey requested review fromegilmorez and removed request forOrlandriaH-GJuly 23, 2025 15:12
Copy link
Contributor

@jonathanedeyjonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Please address the lint error and update the branch, Thanks!

Copy link

@egilmorezegilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG, thanks!

@huwmartin
Copy link
ContributorAuthor

@jonathanedey thanks, lots of other issues when running./lint.sh all locally, CI appears to only lint touched lines(?), so difficult to tell what will snag 😄 I've updated all ofActionCodeSettings.__init__ for consistency.

@jonathanedey
Copy link
Contributor

jonathanedey commentedJul 23, 2025•
edited
Loading

@huwmartin, no worries, those were mainly because the branch was out of date. We made some lint changes in or last release and the CI here are using those settings. Thanks again for you contribution!

@jonathanedeyjonathanedey changed the titleUpdate ActionCodeSettings to support link_domainfeat(auth) UpdateActionCodeSettings to supportlink_domain and deprecatedynamic_link_domainJul 23, 2025
@jonathanedeyjonathanedey merged commit4fa2918 intofirebase:masterJul 23, 2025
10 checks passed
@jonathanedeyjonathanedey changed the titlefeat(auth) UpdateActionCodeSettings to supportlink_domain and deprecatedynamic_link_domainfeat(auth): UpdateActionCodeSettings to supportlink_domain and deprecatedynamic_link_domainJul 23, 2025
jonathanedey pushed a commit that referenced this pull requestAug 13, 2025
…eprecate `dynamic_link_domain` (#884)* Add link_domain to ActionCodeSettings; update encode_action_code_settings to handle link_domain* Add handling for InvalidHostingLinkDomainError* Add deprecation warning for dynamic_link_domain* Update error message for InvalidHostingLinkDomainError* Fix lint* Add type hints to ActionCodeSettings* Fix f-string lint
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Xiaoshouzi-ghXiaoshouzi-ghXiaoshouzi-gh approved these changes

@egilmorezegilmorezegilmorez approved these changes

@jonathanedeyjonathanedeyjonathanedey approved these changes

+1 more reviewer

@errkkerrkkerrkk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lahirumarambalahirumaramba

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@huwmartin@jonathanedey@errkk@egilmorez@Xiaoshouzi-gh@lahirumaramba
[8]ページ先頭
©2009-2025 Movatter.jp