Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update release and ci workflows to useGITHUB_OUTPUT and bumpactions/checkout to v4.#752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jonathanedey merged 2 commits intomasterfromje-github-actions
Jan 3, 2024

Conversation

@jonathanedey
Copy link
Contributor

No description provided.

@jonathanedeyjonathanedey added the release:stageStage a release candidate labelJan 2, 2024
@jonathanedeyjonathanedey changed the titleUpdate release workflow to useGITHUB_OUTPUT and bumpactions/checkout to v4.Update release and ci workflows to useGITHUB_OUTPUT and bumpactions/checkout to v4.Jan 2, 2024
@jonathanedey
Copy link
ContributorAuthor

Currently we use a forked version of a (no longer maintained) release github action which still usesset-output:
https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source likehttps://github.com/ncipollo/release-action?

@jonathanedeyjonathanedey marked this pull request as ready for reviewJanuary 3, 2024 14:29
Copy link
Member

@lahirumarambalahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! LGTM!

@lahirumaramba
Copy link
Member

Currently we use a forked version of a (no longer maintained) release github action which still usesset-output:https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source likehttps://github.com/ncipollo/release-action?

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

@jonathanedey
Copy link
ContributorAuthor

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

The original repothe fork was based on was the official oneuntil they stopped maintaining it in 2021.

They left suggested alternatives with the one i linked being the most active but the thread of mentions shows a few repos who decided to usehttps://github.com/softprops/action-gh-release instead.

lahirumaramba reacted with thumbs up emoji

@jonathanedeyjonathanedey merged commitdf94f8b intomasterJan 3, 2024
@jonathanedeyjonathanedey deleted the je-github-actions branchJanuary 3, 2024 19:41
jonathanedey added a commit that referenced this pull requestFeb 13, 2024
…ons/checkout` to v4. (#752)* Update release workflow to use GITHUB_OUTPUT.* Use actions/checkout@v4 for nightly builds
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lahirumarambalahirumarambalahirumaramba approved these changes

Assignees

@lahirumarambalahirumaramba

Labels

release:stageStage a release candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanedey@lahirumaramba

[8]ページ先頭

©2009-2025 Movatter.jp