Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added type hints#689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mohitCodepy wants to merge1 commit intofirebase:main
base:main
Choose a base branch
Loading
frommohitCodepy:master
Draft

Conversation

@mohitCodepy
Copy link

Added type hints for better readability and correct types.

Related to issue#626

@mohitCodepymohitCodepy marked this pull request as draftMarch 30, 2023 08:00
Copy link
Member

@lahirumarambalahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@mohitCodepy for your contribution. Is this a duplicate of#627 ?

@mohitCodepy
Copy link
Author

mohitCodepy commentedMar 30, 2023•
edited
Loading

Thank you@mohitCodepy for your contribution. Is this a duplicate of#627 ?

@lahirumaramba , Actually#627 has some missing type hints, so this PR currently in draft
I'll make changes to the remaining files and then open this PR for review also fixing the CI along.

Thanks

@mohitCodepy
Copy link
Author

@lahirumaramba ,

May I continue to push changes to this PR?
I want to work regularly

@ViktorSky
Copy link

Was this abandoned?

@ViktorSky
Copy link

I did a similar pull on#877

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lahirumarambalahirumarambalahirumaramba left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohitCodepy@ViktorSky@lahirumaramba
[8]ページ先頭
©2009-2025 Movatter.jp