- Notifications
You must be signed in to change notification settings - Fork342
Added type annotations for public API + flake8 fixes#627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
lahirumaramba commentedJul 26, 2022
Thank you@guneemwelloeux for your contribution! Would you be able to check the failing CIs? Thanks! |
9ac6080 to2119ca3Comparefirebase_admin/__init__.py Outdated
| service.close() | ||
| self._services=None | ||
| App.update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is. Just pushed an update to my branch. I did run the unit tests before, all passed.
lahirumaramba left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please fix the failing CIs. Thanks!
2119ca3 to357278dCompare
Uh oh!
There was an error while loading.Please reload this page.
This relates to issue#626