- Notifications
You must be signed in to change notification settings - Fork400
[Draft] Add generated client files to fcm#1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Note: adding DOM to lib is necessary to make the compiler happy, but shouldn't be a runtime issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks pretty good. We need to figure out a way to resolve the lint errors. Plus some suggestions on the directory structure.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I see that you've nested So lets use the structure you currently have for now. Later we can discuss other approaches for organizing these files in our repo. |
…ly run (#1353)* Update Gulpfile to copy files required for generated code to run.* Fix introduced typo on 104* Remove redundant glob from `copyJson()` task
This PR serves as a proof of concept to show that GAPIC generated clients can be integrated with Firebase Admin APIs. It also shows that this integration for pre-existing APIs requires a relatively substantial amount of work.
[Draft]
The result of moving autogenerated fcm client code usingGAPIC into the messaging directory. Subsequent PRs will be made into this branch as development continues (namely, migrating to the generated client overmessaging-api-request-internal.ts
This is part of an ongoing internship project/experiment in the feasibility of using autogenerated clients, which will hopefully make supporting multiple apis across multiple languages easier in the long term.