Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:faye/websocket-extensions-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base:0.1.3
Choose a base ref
Loading
...
head repository:faye/websocket-extensions-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare:0.1.4
Choose a head ref
Loading
  • 8commits
  • 13files changed
  • 1contributor

Commits on May 24, 2019

  1. Configuration menu
    Copy the full SHA
    729a465View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b62083View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Configuration menu
    Copy the full SHA
    2d211f3View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Configuration menu
    Copy the full SHA
    f6c50abView commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. 1Configuration menu
    Copy the full SHA
    44a677aView commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. 1Configuration menu
    Copy the full SHA
    4a76c75View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser

    There is a regular expression denial of service (ReDoS) vulnerability inthe parser we use to process the `Sec-WebSocket-Extensions` header. Itcan be exploited by sending an opening WebSocket handshake to a servercontaining a header of the form:    Sec-WebSocket-Extensions: a;b="\c\c\c\c\c\c\c\c\c\c ...i.e. a header containing an unclosed string parameter value whosecontent is a repeating two-byte sequence of a backslash and some othercharacter. The parser takes exponential time to reject this header asinvalid, and this can be used to exhaust the server's capacity toprocess requests.This vulnerability has been assigned the identifierCVE-2020-7662 andwas reported by Robert McLaughlin.We believe this flaw stems from the grammar specified for this header.[RFC 6455][1] defines the grammar for the header as:    Sec-WebSocket-Extensions = extension-list    extension-list    = 1#extension    extension         = extension-token *( ";" extension-param )    extension-token   = registered-token    registered-token  = token    extension-param   = token [ "=" (token | quoted-string) ]It refers to [RFC 2616][2] for the definitions of `token` and`quoted-string`, which are:    token          = 1*<any CHAR except CTLs or separators>    separators     = "(" | ")" | "<" | ">" | "@"                   | "," | ";" | ":" | "\" | <">                   | "/" | "[" | "]" | "?" | "="                   | "{" | "}" | SP | HT    quoted-string  = ( <"> *(qdtext | quoted-pair ) <"> )    qdtext         = <any TEXT except <">>    quoted-pair    = "\" CHARThese rely on the `CHAR`, `CTL` and `TEXT` grammars, which are:    CHAR           = <any US-ASCII character (octets 0 - 127)>    CTL            = <any US-ASCII control character (octets 0 - 31) and DEL (127)>    TEXT           = <any OCTET except CTLs, but including LWS>Other relevant definitions to support these:    OCTET          = <any 8-bit sequence of data>    LWS            = [CRLF] 1*( SP | HT )    CRLF           = CR LF    HT             = <US-ASCII HT, horizontal-tab (9)>    LF             = <US-ASCII LF, linefeed (10)>    CR             = <US-ASCII CR, carriage return (13)>    SP             = <US-ASCII SP, space (32)>To expand some of these terms out and write them as regular expressions:    OCTET         = [\x00-\xFF]    CHAR          = [\x00-\x7F]    TEXT          = [\t \x21-\x7E\x80-\xFF]The allowable bytes for `token` are [\x00-\x7F], except [\x00-\x1F\x7F](leaving [\x20-\x7E]) and `separators`, which leaves the following setof allowed chars:    ! # $ % & ' * + - . ^ _ ` | ~ [0-9] [A-Z] [a-z]`quoted-string` contains a repeated pattern of either `qdtext` or`quoted-pair`. `qdtext` is any `TEXT` byte except <">, and the <">character is ASCII 34, or 0x22. The <!> character is 0x21. So `qdtext`can be written either positively as:    qdtext        = [\t !\x23-\x7E\x80-\xFF]or negatively, as:    qdtext        = [^\x00-\x08\x0A-\x1F\x7F"]We use the negative definition here. The other alternative in the`quoted-string` pattern is:    quoted-pair   = \\[\x00-\x7F]The problem is that the set of bytes matched by `qdtext` includes <\>,and intersects with the second element of `quoted-pair`. That means thesequence \c can be matched as either two `qdtext` bytes, or as a single`quoted-pair`. When the regex engine fails to find a trailing <"> toclose the string, it back-tracks and tries every alternate parse for thestring, which doubles with each pair of bytes in the input.To fix the ReDoS flaw we need to rewrite the repeating pattern so thatnone of its alternate branches can match the same text. For example, wecould try dividing the set of bytes [\x00-\xFF] into those that must notfollow a <\>, those that may follow a <\>, and those that must bepreceded by <\>, and thereby construct a pattern of the form:    (A|\?B|\C)*where A, B and C have no characters in common. In our case the threebranch patterns would be:    A   =   qdtext - CHAR   =   [\x80-\xFF]    B   =   qdtext & CHAR   =   [\t !\x23-\x7E]    C   =   CHAR - qdtext   =   [\x00-\x08\x0A-\x1F\x7F"]These sets do not intersect, and notice <"> appears in set C so must bepreceded by <\>. But we still have a problem: <\> (0x5C) and all thealphabetic characters are in set B, so the pattern \?B can match allthese:    c    \    \cSo the sequence \c\c\c... still produces exponential back-tracking. Italso fails to parse input like this correctly:    Sec-WebSocket-Extensions: a; b="c\", d"Because the grammar allows a single backslash to appear by itself, thisis arguably a syntax error where the parameter `b` has value `c\` andthen a new extension `d` begins with a <"> appearing where it shouldnot.So the core problem is with the grammar itself: `qdtext` matches asingle backslash <\>, and `quoted-pair` matches a pair <\\>. So given asequence of backslashes there's no canonical parse and the grammar isambiguous.[RFC 7230][3] remedies this problem and makes the grammar clearer.First, it defines `token` explicitly rather than implicitly:    token          = 1*tchar    tchar          = "!" / "#" / "$" / "%" / "&" / "'" / "*"                   / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"                   / DIGIT / ALPHAAnd second, it defines `quoted-string` so that backslashes cannot appearon their own:     quoted-string  = DQUOTE *( qdtext / quoted-pair ) DQUOTE     qdtext         = HTAB / SP /%x21 / %x23-5B / %x5D-7E / obs-text     obs-text       = %x80-FF     quoted-pair    = "\" ( HTAB / SP / VCHAR / obs-text )where VCHAR is any printing ASCII character 0x21-0x7E. Notice `qdtext`is just our previous definition but with 5C excluded, so it cannotaccept a single backslash.This commit makes this modification to our matching patterns, andthereby removes the ReDoS vector. Technically this means it does notmatch the grammar of RFC 6455, but we expect this to have little or nopractical impact, especially since the one main protocol extension,`permessage-deflate` ([RFC 7692][4]), does not have any string-valuedparameters.[1]:https://tools.ietf.org/html/rfc6455#section-9.1[2]:https://tools.ietf.org/html/rfc2616#section-2.2[3]:https://tools.ietf.org/html/rfc7230#section-3.2.6[4]:https://tools.ietf.org/html/rfc7692
    @jcoglan
    jcoglan committedJun 2, 2020
    Configuration menu
    Copy the full SHA
    29496f6View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.1.4

    @jcoglan
    jcoglan committedJun 2, 2020
    2Configuration menu
    Copy the full SHA
    5ea0b42View commit details
    Browse the repository at this point in the history
Loading

[8]ページ先頭

©2009-2025 Movatter.jp