Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: resolve 6 failing Playwright E2E tests#2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
fitchmultz wants to merge1 commit intofastapi:master
base:master
Choose a base branch
Loading
fromfitchmultz:fix/playwright-e2e-tests

Conversation

@fitchmultz
Copy link

@fitchmultzfitchmultz commentedDec 14, 2025
edited
Loading

Summary

This PR fixes 6 failing Playwright E2E tests by addressing root causes in both the frontend validation schemas and test implementations.

Issues Fixed

Email Validation Messages (4 tests)

  • Tests expected "Invalid email address" but Zod's default message was different
  • Added custom error message{ message: "Invalid email address" } to email validation in:
    • login.tsx
    • signup.tsx
    • recover-password.tsx

Password Reset Tests (2 tests)

  • Tests were polling mailcatcher before the email was sent
  • Added wait for success toast "Password recovery email sent successfully" before polling

Sign Up with Existing Email (1 test)

  • Test didn't wait for first signup to complete before attempting second signup
  • Changed assertion from.click() to proper.toBeVisible()

Root Cause Fix

  • FixedsignUpNewUser utility to wait for signup completion (waitForURL("/login")) instead of immediately navigating away

Test Plan

  • All 41 Playwright tests pass locally
  • Changes are minimal and targeted to fix only the failing tests

Files Changed

  • frontend/src/routes/login.tsx
  • frontend/src/routes/signup.tsx
  • frontend/src/routes/recover-password.tsx
  • frontend/tests/reset-password.spec.ts
  • frontend/tests/sign-up.spec.ts
  • frontend/tests/utils/user.ts

- Add custom "Invalid email address" validation message to Zod schemas  in login, signup, and recover-password routes (fixes 4 tests)- Wait for success toast before polling mailcatcher in password reset  tests (fixes 2 tests)- Fix sign-up with existing email test to wait for first signup and  use proper toBeVisible() assertion (fixes 1 test)- Fix signUpNewUser utility to wait for signup completion before  navigating🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fitchmultz

[8]ページ先頭

©2009-2025 Movatter.jp