Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
refactor: Improve type annotations and use python 3.10+ syntax#14943
Open
argoarsiks wants to merge 1 commit intofastapi:masterfrom
Open
refactor: Improve type annotations and use python 3.10+ syntax#14943argoarsiks wants to merge 1 commit intofastapi:masterfrom
argoarsiks wants to merge 1 commit intofastapi:masterfrom
Conversation
codspeed-hqbot commentedFeb 19, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
fastapi/dependencies/utils.py Outdated
| def is_union_of_base_models(field_type:Any) -> bool: | ||
| def is_union_of_base_models(field_type:type) -> bool: |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
mypy check...............................................................Failed- hook id: local-mypy- exit code: 1 fastapi/dependencies/utils.py:866: error: Argument 1 to "is_union_of_base_models" has incompatible type "type[Any] | None"; expected "type" [arg-type] Found 1 error in 1 file (checked 47 source files)5f006e5 to1f89f7bCompare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X | Ysyntax for isinstance calls