Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

🐛 Fix implicit path params with converters#14883

Open
Dawaman43 wants to merge 4 commits intofastapi:masterfrom
Dawaman43:fix-path-converter-path-params
Open

🐛 Fix implicit path params with converters#14883
Dawaman43 wants to merge 4 commits intofastapi:masterfrom
Dawaman43:fix-path-converter-path-params

Conversation

@Dawaman43
Copy link

Summary

Routes that use path converters (e.g.{param:path}) are not detected as path parameters when the parameter is declared implicitly
(withoutPath()), becauseget_path_param_names() returns the raw token including the converter suffix.

This causes the parameter to be treated as a query parameter and the request to fail.

Changes Made

  • Strip converter suffixes inget_path_param_names() so{param:path} is recognized asparam.
  • Add a regression test that verifies an implicitparam: str path parameter works with thepath converter.

Why it matters

This aligns implicit parameters with explicitPath() behavior and restores correct routing for path-converter syntax.

Testing

  • Added a focused test intests/test_starlette_urlconvertors.py.

@YuriiMotovYuriiMotov changed the titleFix implicit path params with Fix implicit path params with convertersconverters🐛 Fix implicit path params with convertersFeb 10, 2026
@YuriiMotovYuriiMotov added the bugSomething isn't working labelFeb 10, 2026
@codspeed-hq
Copy link

codspeed-hqbot commentedFeb 10, 2026
edited
Loading

Merging this PR willnot alter performance

✅ 20 untouched benchmarks


ComparingDawaman43:fix-path-converter-path-params (cbc1039) withmaster (a2e5136)

Open in CodSpeed

Copy link
Member

@YuriiMotovYuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@Dawaman43, thanks!

Dawaman43 reacted with thumbs up emoji
@YuriiMotov
Copy link
Member

YuriiMotov commentedFeb 10, 2026
edited
Loading

@Dawaman43, please don't mergemaster branch so often - it creates noise in the notifications.
We will update branch before final review

@Dawaman43
Copy link
Author

Dawaman43 commentedFeb 10, 2026 via email

ok sorry
On Tue, 10 Feb 2026 at 15:01, Motov Yurii ***@***.***> wrote: *YuriiMotov* left a comment (fastapi/fastapi#14883) <#14883 (comment)>@Dawaman43 <https://github.com/Dawaman43>, please don't merge master branch so often - it creates noise in the notifications — Reply to this email directly, view it on GitHub <#14883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BCKYMSHQ46W44ZLPHOM4F3L4LHCCJAVCNFSM6AAAAACUS4GUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZXGE3TGNBQGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@YuriiMotovYuriiMotovYuriiMotov approved these changes

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dawaman43@YuriiMotov

[8]ページ先頭

©2009-2026 Movatter.jp