Merging this PR willnot alter performance

✅ 20 untouched benchmarks

_{Comparingollie-bell:feat/support-starlettte-request-generic (c940ab7) withmaster (faee822)¹}

The test run for python 3.9 which uses lowest-direct resolution picks up starlette 0.45.3, which doesn't have this feature available - should the newly added test be marked asxfail forstarlette < 0.52.0?

The test run for python 3.9 which uses lowest-direct resolution picks up starlette 0.45.3, which doesn't have this feature available - should the newly added test be marked asxfail forstarlette < 0.52.0?

I think we should just skip it for starlette less than 0.52.0 (@pytest.mark.skipif())

📝 Docs preview

Last commit940aa5d at:https://8b5ff73f.fastapitiangolo.pages.dev

I think we should just skip it for starlette less than 0.52.0 (@pytest.mark.skipif())

Thanks, that's done now ✅ I introduced thepackaging dependency into thetests dependency group to do the version comparison in a robust way.

I introduced thepackaging dependency into thetests dependency group to do the version comparison in a robust way.

I would actually avoid adding new dependency for this - it's quite easy to parse version number into a tuple and compare with(0, 52, 0).
But we can wait for the feedback from Sebastian and update it if he requests it

I would actually avoid adding new dependency for this

That's understood - I've updated to parsestarlette.__version__ into a tuple for comparison, consistent with an existing pattern used elsewhere

This pull request has a merge conflict that needs to be resolved.