Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
🐛 Fix support forStreamingResponses with dependencies withyield orUploadFiles, close after the response is done#14099
Conversation
…endencies with yield
…d, as those caused memory issues before
…rated background tasks
…from dependencies AsyncExitStack
Contributor
📝 Docs preview for commit9087a2a at:https://3154752a.fastapitiangolo.pages.dev Modified Pages |
Contributor
📝 Docs preview for commit343d3a2 at:https://01ef1bba.fastapitiangolo.pages.dev Modified Pages |
Contributor
This was referencedSep 21, 2025
yield, close after the response is doneStreamingResponses with dependencies withyield orUploadFiles, close after the response is doneContributor
Contributor
e329d78 intomaster 53 of 54 checks passed
Uh oh!
There was an error while loading.Please reload this page.
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestOct 1, 2025
YuriiMotov added a commit that referenced this pull requestOct 1, 2025
anton-ryzhov commentedOct 3, 2025
This PR also fixes#12508 |
anton-ryzhov commentedJan 2, 2026
But introduces another bug as describedhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
🐛 Fix support for
StreamingResponses with dependencies withyieldorUploadFiles, close after the response is doneThere's (again) an
AsyncExitStackmiddleware, now used mainly to close objects after the response is done.There's also a new wrapper duplicating some logic in Starlette but creating an
AsyncExitStackfor the exit code in dependencies withyield, for regular responses and WebSockets as well.The exit code of dependencies with
yieldis now executed after the response is done.