Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
📝 Remove links to site callbackhell.com that doesn't exist anymore#14006
Merged
tiangolo merged 1 commit intofastapi:masterfromAug 31, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, this looks good!
I would also remove the links to callbackhell.ru just for consistency.
Then, I worry a bit that the current text is not super informative:
In previous versions of NodeJS / Browser JavaScript, you would have used "callbacks". Which leads to callback hell.
Before, the link was there to explain more, but now to someone unfamiliar to this concept, this explanation is not really sufficient. I would either
- put "callback hell" in quotes, to clarify it's a common concept that people could google
- change the link to a new one, maybehttps://www.geeksforgeeks.org/javascript/what-to-understand-callback-and-callback-hell-in-javascript/ ?
- add a (very brief) description to the sentence, something like "... to callback hell, a problem occurring due to excessive nesting of functions", or something such. The downside then is that we'd need to translate this to all the languages that are being edited here 😬
What do you think,@dennybiasiolli ?
ContributorAuthor
dennybiasiolli commentedAug 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@svlandeg I think the first option is the easiest, but I can even change the link to the new one. The only (future) problem could be that the link goes offline again, so maybe it's better to leave "callback hell" in quotes and people could google that. I can do those changes right now if you are happy with them, and also removing the callbackhell.ru links |
Member
svlandeg commentedAug 22, 2025
That'd be great, thanks. Yea let's stick to having the concept in quotes. |
in favour of the value ?callback hell' in quotes,so users can google that if they want
abd69b2 toc8f572fCompareContributor
Uh oh!
There was an error while loading.Please reload this page.
svlandeg approved these changesAug 25, 2025
Member
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, looks good to me!
tiangolo approved these changesAug 31, 2025
Member
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, thank you! 🚀
408b8a9 intofastapi:master 52 checks passed
Uh oh!
There was an error while loading.Please reload this page.
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestSep 1, 2025
commit176cd8cAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 15:20:12 2025 +0000 📝 Update release notes [skip ci]commit1884d76Author: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 17:19:49 2025 +0200 🔧 Update sponsors: remove Platform.sh (fastapi#14027)commit8062aabAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 15:02:29 2025 +0000 📝 Update release notes [skip ci]commitee9ccacAuthor: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 17:02:08 2025 +0200 🔧 Update sponsors: remove Mobb (fastapi#14026)commit5cd4c3bAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:59:17 2025 +0000 📝 Update release notes [skip ci]commit4584f70Author: Jom Karlo Verzosa <jomkarlov@gmail.com>Date: Sun Aug 31 18:58:56 2025 +0800 📝 Add deprecation info block about `dict()` in `docs/tutorial/body.md` (fastapi#13906) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commitba9c8fbAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:50:12 2025 +0000 📝 Update release notes [skip ci]commitd9249c1Author: Valentyn <valentin.druzhinin@gmail.com>Date: Sun Aug 31 06:49:48 2025 -0400 📝 Fix Twitter to be X (Twitter) everywhere in documentation (fastapi#13809) Co-authored-by: Valentyn Druzhynin <v.druzhynin@zakaz.global> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commita973e78Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:33:32 2025 +0000 📝 Update release notes [skip ci]commit1088d2aAuthor: Ashish Pandey <126683810+Ashish-Pandey62@users.noreply.github.com>Date: Sun Aug 31 16:17:57 2025 +0545 🐛 Prevent scroll-to-top on restart/fast buttons in `termynal.js` (fastapi#13714) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commit98ec6a6Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:29:48 2025 +0000 📝 Update release notes [skip ci]commit6b4d292Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:29:27 2025 +0000 📝 Update release notes [skip ci]commitd4ddcc5Author: z0z0r4 <z0z0r4@outlook.com>Date: Sun Aug 31 18:29:21 2025 +0800 📝 Update testing events documentation (fastapi#13259) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commit0e5832aAuthor: Hotah Ma <mahongtao0x7e0@163.com>Date: Sun Aug 31 18:29:01 2025 +0800 📝 Remove obsolete `url` field in error responses in docs (fastapi#13655) Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>commitee2acd8Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:03:35 2025 +0000 📝 Update release notes [skip ci]commite902ed5Author: Arnaud Durand <arnaud.durand@live.com>Date: Sun Aug 31 12:03:10 2025 +0200 📝 Bring the `scope` claim in line with the standard in `docs_src/security/tutorial005.py` (fastapi#11189) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>commitcef1f16Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:59:28 2025 +0000 📝 Update release notes [skip ci]commit8e63f75Author: Soul Lee <alus20x@gmail.com>Date: Sun Aug 31 18:59:07 2025 +0900 📝 Update TrustedHostMiddleware Documentation (fastapi#11441) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com> Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com> Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>commite1b9cc0Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:56:48 2025 +0000 📝 Update release notes [skip ci]commit408b8a9Author: Denny Biasiolli <dennybiasiolli@users.noreply.github.com>Date: Sun Aug 31 11:56:21 2025 +0200 📝 Remove links to site callbackhell.com that doesn't exist anymore (fastapi#14006)commit0817c95Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:16:03 2025 +0000 📝 Update release notes [skip ci]commitc55f713Author: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>Date: Sun Aug 31 11:15:41 2025 +0200 📝 Add permalinks to headers in English docs (fastapi#13993) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commit7653de2Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:11:36 2025 +0000 📝 Update release notes [skip ci]commit784f068Author: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 11:11:15 2025 +0200 🛠️ Update `mkdocs_hooks` to handle headers with permalinks when building docs (fastapi#14025) Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>commit6db0577Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 25 20:03:24 2025 +0000 📝 Update release notes [skip ci]commit6be02e3Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Date: Mon Aug 25 22:03:02 2025 +0200 ⬆ [pre-commit.ci] pre-commit autoupdate (fastapi#14016) updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.9 → v0.12.10](astral-sh/ruff-pre-commit@v0.12.9...v0.12.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commit9cf7b70Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Wed Aug 20 09:11:20 2025 +0000 📝 Update release notes [skip ci]commitf75c153Author: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>Date: Wed Aug 20 11:10:51 2025 +0200 ⬆ Bump `mkdocs-macros-plugin` from 1.3.7 to 1.3.9 (fastapi#14003) Bump mkdocs-macros-plugin from 1.3.7 to 1.3.9commit5c3a70dAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 18 21:07:25 2025 +0000 📝 Update release notes [skip ci]commit6a45249Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Date: Mon Aug 18 23:07:04 2025 +0200 ⬆ [pre-commit.ci] pre-commit autoupdate (fastapi#13999) updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.8 → v0.12.9](astral-sh/ruff-pre-commit@v0.12.8...v0.12.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commitc230516Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 18 06:35:06 2025 +0000 📝 Update release notes [skip ci]commitdf77988Author: Mika <44454249+anfreshman@users.noreply.github.com>Date: Mon Aug 18 14:34:40 2025 +0800 📝 Fix code include for Pydantic models example in `docs/zh/docs/python-types.md` (fastapi#13997) Updated the Pydantic expiration example in the Chinese documentation
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestSep 1, 2025
commit3e2dbf9Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 19:34:37 2025 +0000 📝 Update release notes [skip ci]commitf5b77ffAuthor: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 21:34:08 2025 +0200 📝 Add documentation for Behind a Proxy - Proxy Forwarded Headers, using `--forwarded-allow-ips="*"` (fastapi#14028) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commit176cd8cAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 15:20:12 2025 +0000 📝 Update release notes [skip ci]commit1884d76Author: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 17:19:49 2025 +0200 🔧 Update sponsors: remove Platform.sh (fastapi#14027)commit8062aabAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 15:02:29 2025 +0000 📝 Update release notes [skip ci]commitee9ccacAuthor: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 17:02:08 2025 +0200 🔧 Update sponsors: remove Mobb (fastapi#14026)commit5cd4c3bAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:59:17 2025 +0000 📝 Update release notes [skip ci]commit4584f70Author: Jom Karlo Verzosa <jomkarlov@gmail.com>Date: Sun Aug 31 18:58:56 2025 +0800 📝 Add deprecation info block about `dict()` in `docs/tutorial/body.md` (fastapi#13906) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commitba9c8fbAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:50:12 2025 +0000 📝 Update release notes [skip ci]commitd9249c1Author: Valentyn <valentin.druzhinin@gmail.com>Date: Sun Aug 31 06:49:48 2025 -0400 📝 Fix Twitter to be X (Twitter) everywhere in documentation (fastapi#13809) Co-authored-by: Valentyn Druzhynin <v.druzhynin@zakaz.global> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commita973e78Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:33:32 2025 +0000 📝 Update release notes [skip ci]commit1088d2aAuthor: Ashish Pandey <126683810+Ashish-Pandey62@users.noreply.github.com>Date: Sun Aug 31 16:17:57 2025 +0545 🐛 Prevent scroll-to-top on restart/fast buttons in `termynal.js` (fastapi#13714) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commit98ec6a6Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:29:48 2025 +0000 📝 Update release notes [skip ci]commit6b4d292Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:29:27 2025 +0000 📝 Update release notes [skip ci]commitd4ddcc5Author: z0z0r4 <z0z0r4@outlook.com>Date: Sun Aug 31 18:29:21 2025 +0800 📝 Update testing events documentation (fastapi#13259) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commit0e5832aAuthor: Hotah Ma <mahongtao0x7e0@163.com>Date: Sun Aug 31 18:29:01 2025 +0800 📝 Remove obsolete `url` field in error responses in docs (fastapi#13655) Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>commitee2acd8Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 10:03:35 2025 +0000 📝 Update release notes [skip ci]commite902ed5Author: Arnaud Durand <arnaud.durand@live.com>Date: Sun Aug 31 12:03:10 2025 +0200 📝 Bring the `scope` claim in line with the standard in `docs_src/security/tutorial005.py` (fastapi#11189) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>commitcef1f16Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:59:28 2025 +0000 📝 Update release notes [skip ci]commit8e63f75Author: Soul Lee <alus20x@gmail.com>Date: Sun Aug 31 18:59:07 2025 +0900 📝 Update TrustedHostMiddleware Documentation (fastapi#11441) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com> Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com> Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>commite1b9cc0Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:56:48 2025 +0000 📝 Update release notes [skip ci]commit408b8a9Author: Denny Biasiolli <dennybiasiolli@users.noreply.github.com>Date: Sun Aug 31 11:56:21 2025 +0200 📝 Remove links to site callbackhell.com that doesn't exist anymore (fastapi#14006)commit0817c95Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:16:03 2025 +0000 📝 Update release notes [skip ci]commitc55f713Author: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>Date: Sun Aug 31 11:15:41 2025 +0200 📝 Add permalinks to headers in English docs (fastapi#13993) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>commit7653de2Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Sun Aug 31 09:11:36 2025 +0000 📝 Update release notes [skip ci]commit784f068Author: Sebastián Ramírez <tiangolo@gmail.com>Date: Sun Aug 31 11:11:15 2025 +0200 🛠️ Update `mkdocs_hooks` to handle headers with permalinks when building docs (fastapi#14025) Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>commit6db0577Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 25 20:03:24 2025 +0000 📝 Update release notes [skip ci]commit6be02e3Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Date: Mon Aug 25 22:03:02 2025 +0200 ⬆ [pre-commit.ci] pre-commit autoupdate (fastapi#14016) updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.9 → v0.12.10](astral-sh/ruff-pre-commit@v0.12.9...v0.12.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commit9cf7b70Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Wed Aug 20 09:11:20 2025 +0000 📝 Update release notes [skip ci]commitf75c153Author: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>Date: Wed Aug 20 11:10:51 2025 +0200 ⬆ Bump `mkdocs-macros-plugin` from 1.3.7 to 1.3.9 (fastapi#14003) Bump mkdocs-macros-plugin from 1.3.7 to 1.3.9commit5c3a70dAuthor: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 18 21:07:25 2025 +0000 📝 Update release notes [skip ci]commit6a45249Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Date: Mon Aug 18 23:07:04 2025 +0200 ⬆ [pre-commit.ci] pre-commit autoupdate (fastapi#13999) updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.8 → v0.12.9](astral-sh/ruff-pre-commit@v0.12.8...v0.12.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>commitc230516Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Date: Mon Aug 18 06:35:06 2025 +0000 📝 Update release notes [skip ci]commitdf77988Author: Mika <44454249+anfreshman@users.noreply.github.com>Date: Mon Aug 18 14:34:40 2025 +0800 📝 Fix code include for Pydantic models example in `docs/zh/docs/python-types.md` (fastapi#13997) Updated the Pydantic expiration example in the Chinese documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed them walking through the "Learn" doc in the website. The website callbackhell.com does not exists anymore.
Links pointing to callbackhell.ru are still working, but if you want I can remove them as well for consistency.