Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
🔨 Update translations script#13968
Merged
tiangolo merged 9 commits intofastapi:masterfromSep 20, 2025
Merged
Conversation
Otherwise it raises on my Windows, as it tries to use the system encoding, which is not utf-8.
nilslindemann approved these changesAug 4, 2025
Contributor
nilslindemann left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good 👍
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestAug 5, 2025
seefastapi@da9659bThis adds anchors to headings, so that links with hashes stay in the translation.
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestAug 5, 2025
Before, it sometimes still wrapped the translation with "```markdown" and "```". Now not anymore.Yurii, If you agree with that change, please apply tofastapi#13968 (update-translations-prompt)
Contributor
nilslindemann commentedAug 5, 2025
Hi Yurii, good addition! I tested with the recent German translations and it works great! Seehere (the commits from Aug 5). |
This comment was marked as off-topic.
This comment was marked as off-topic.
nilslindemann approved these changesAug 17, 2025
nilslindemann approved these changesSep 5, 2025
Contributor
nilslindemann left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good 👍
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull requestSep 6, 2025
Let's handle these changes in another PR.Except the modifications in the prompt, this translate.py is now in sync with the translate.py in update-translations-prompt (fastapi#13968).
Contributor
nilslindemann commentedSep 6, 2025
nilslindemann approved these changesSep 8, 2025
tiangolo approved these changesSep 20, 2025
Member
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome, thank you@YuriiMotov and@nilslindemann! 🙌 🤖 🚀
4c9c3b5 intofastapi:master 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.