Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fixed CWE-79 on docs.py#13887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
LucaPaterlini wants to merge1 commit intofastapi:master
base:master
Choose a base branch
Loading
fromLucaPaterlini:sec-vln-fix/CWE-79

Conversation

LucaPaterlini
Copy link

No description provided.

@LucaPaterlini
Copy link
Author

probably was needed to make the flaky test pass for the documentation...

@YuriiMotov
Copy link
Contributor

@LucaPaterlini, thanks for the interest in FastAPI!
Could you please add more reasoning on why we need to add this?

@LucaPaterlini
Copy link
Author

https://cwe.mitre.org/data/definitions/79.html
there is a CWE about not checking the parsed input.
Shall we assume the input is safe on Template?

Thanks for your replies was not expecting this celery response, great fan of your work guys

@YuriiMotov
Copy link
Contributor

YuriiMotov commentedJul 13, 2025
edited
Loading

https://cwe.mitre.org/data/definitions/79.html there is a CWE about not checking the parsed input. Shall we assume the input is safe on Template?

So, as I understand it, the intruder can open a PR that injects malicious code in docs. And if somebody tries opening automatically generated docs preview that injected code may be executed on client side. Right?
I don't think it's possible that we have such malicious code inmaster, but the situation described above looks possible.

Do you have any idea why "Building Docs" action fails?

@YuriiMotov
Copy link
Contributor

As an alternative approach, we can disable automatic docs preview deployments for PRs and do it only after maintainers check the diff and explicitly request it

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@LucaPaterlini@YuriiMotov

[8]ページ先頭

©2009-2025 Movatter.jp