Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
✅ Fix a minor bug in the testtests/test_modules_same_name_body/test_main.py#13411
Merged
tiangolo merged 3 commits intofastapi:masterfromFeb 27, 2025
Merged
Conversation
tests/test_modules_same_name_body/test_main.pytests/test_modules_same_name_body/test_main.pytests/test_modules_same_name_body/test_main.pytests/test_modules_same_name_body/test_main.pysvlandeg approved these changesFeb 24, 2025
Member
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch with the missingassert!
Also a good idea to useparametrize here and avoid code duplication to test all corner cases.
Should be ready to merge 🥳
tests/test_modules_same_name_body/test_main.pytests/test_modules_same_name_body/test_main.pytiangolo approved these changesFeb 27, 2025
Member
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! 🚀 🎉
7eabff4 intofastapi:master 31 of 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description:
1.
has been replaced with the assertion statement
Tests parametrization applied to reduce the duplicated code