Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🌐 Add Korean translation fordocs/ko/docs/tutorial/security/oauth2-jwt.md#13333

Merged
alejsdev merged 19 commits intofastapi:masterfrom
yes0ng:feature/translation-docs-ko-oauth2-jwt
Mar 10, 2025
Merged

🌐 Add Korean translation fordocs/ko/docs/tutorial/security/oauth2-jwt.md#13333
alejsdev merged 19 commits intofastapi:masterfrom
yes0ng:feature/translation-docs-ko-oauth2-jwt

Conversation

@yes0ng
Copy link
Contributor

@yes0ngyes0ng commentedFeb 8, 2025•
edited
Loading

Hello! This is my first translation, so it may be lacking a lot.

If there are any Korean translation guidelines in this repo, please let me know.
I found discussion(#3167) late and corrected it a little more.

I would greatly appreciate any feedback 🙇‍♀️

✏️ Note

1️⃣ There is some paraphrasing. Some sentences have been reconstructed to a level that is easy for Koreans to read without damaging the meaning of the original text. (I think that simple word translations could be handled well by browser translation features.)

2️⃣ For consistency within thesecurity subdocuments, I translated "password" into "패스워드" according to thesimple-oauth2.md, instead of "비밀번호"

timothy-jeong reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the lang-allTranslations labelFeb 8, 2025
@github-actions
Copy link
Contributor

@yes0ngyes0ng changed the title🌐 Add Korean translation for /docs/ko/docs/tutorial/security/oauth2-jwt.md🌐 Add Korean translation for docs/ko/docs/tutorial/security/oauth2-jwt.mdFeb 8, 2025
@alejsdevalejsdev changed the title🌐 Add Korean translation for docs/ko/docs/tutorial/security/oauth2-jwt.md🌐 Add Korean translation fordocs/ko/docs/tutorial/security/oauth2-jwt.mdFeb 8, 2025
@alejsdevalejsdev added awaiting-review lang-koKorean translations labelsFeb 8, 2025
@github-actions
Copy link
Contributor

Copy link
Contributor

@timothy-jeongtimothy-jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What a huge document!

yes0ng reacted with heart emoji
yes0ngand others added7 commitsFebruary 11, 2025 00:19
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
@github-actions
Copy link
Contributor

Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
@github-actions
Copy link
Contributor

yes0ngand others added2 commitsFebruary 12, 2025 01:54
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
Co-authored-by: �timothy <53824764+timothy-jeong@users.noreply.github.com>
@github-actions
Copy link
Contributor

Copy link
Contributor

@timothy-jeongtimothy-jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

yes0ng reacted with heart emoji
@yes0ng
Copy link
ContributorAuthor

LGTM 🚀

Thank you for helping me with my first, inexperienced translation. Thanks to you, I was able to identify several mistranslations. And I had a meaningful time reflecting on them. 🙏

timothy-jeong reacted with laugh emoji

Copy link

@sodaMelonsodaMelon left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hi. i left some comment for you.
Here's a tip: when you've written a long sentence, read it out loud to yourself. Then you can find something awkward in yours.

yes0ng reacted with heart emoji
yes0ngand others added2 commitsFebruary 20, 2025 00:28
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions
Copy link
Contributor

yes0ngand others added3 commitsFebruary 20, 2025 00:39
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@yes0ng
Copy link
ContributorAuthor

hi. i left some comment for you. Here's a tip: when you've written a long sentence, read it out loud to yourself. Then you can find something awkward in yours.

안녕하세요. 친절하게 도움 주셔서 감사합니다.
코멘트 주신 부분 외에도, 전체적으로 소리내어 읽어보며 어색한 부분을 조금 더 수정했습니다.

제안 주신 내용을 그대로 수용한 경우 resolved 로 변경하였고,
조금 다르게 반영한 경우 추가 검토가 필요하다고 판단하여 unresolved 상태로 남겨두었습니다 :)

sodaMelon reacted with thumbs up emoji

Copy link

@sodaMelonsodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm@yes0ng 👍
sorry for late response im stuck irl

문장이 훨씬 좋아졌네요!! 승인 늦어서 죄송해요ㅠㅠ 고생하셨습니다!

yes0ng reacted with heart emoji
@yes0ng
Copy link
ContributorAuthor

lgtm@yes0ng 👍 sorry for late response im stuck irl

문장이 훨씬 좋아졌네요!! 승인 늦어서 죄송해요ㅠㅠ 고생하셨습니다!

덕분에 많이 배웠습니다! 꼼꼼히 봐주셔서 감사합니다 🙏

sodaMelon reacted with heart emojisodaMelon reacted with rocket emoji

@alejsdevalejsdev merged commit3565ea0 intofastapi:masterMar 10, 2025
58 checks passed
@alejsdev
Copy link
Member

Thank you for your contribution!@yes0ng 🚀
And thanks for your help@timothy-jeong@sodaMelon 🔍 ✨

yes0ng reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@timothy-jeongtimothy-jeongtimothy-jeong approved these changes

@sodaMelonsodaMelonsodaMelon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-koKorean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yes0ng@alejsdev@timothy-jeong@sodaMelon

Comments

[8]ページ先頭
©2009-2026 Movatter.jp