Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
🌐 Add Korean translation fordocs/ko/docs/advanced/custom-response.md#13265
🌐 Add Korean translation fordocs/ko/docs/advanced/custom-response.md#13265alejsdev merged 23 commits intofastapi:masterfrom
docs/ko/docs/advanced/custom-response.md#13265Conversation
…dencies-with-yield.md
docs/ko/docs/advanced/custom-response.md📝 Docs preview for commit17d3ddd at:https://a6040df4.fastapitiangolo.pages.dev Modified Pages |
17d3ddd tocb4b699Compare📝 Docs preview for commit47ed3a7 at:https://cf889d8c.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commit0305270 at:https://8a7fd4f2.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commit97f0245 at:https://1e20118e.fastapitiangolo.pages.dev Modified Pages |
| 예를 들어, 성능을 극대화하려는 경우, <a href="https://github.com/ijl/orjson" class="external-link" target="_blank">orjson</a>을 설치하여 사용하고 응답을 `ORJSONResponse`로 설정 할수 있습니다. | ||
| 사용하고자 하는 `Response` 클래스(하위 클래스)를 가져와서 **경로 작동 테코레이터*에서 선언하세요. |
timothy-jeongFeb 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for your �Awesome Job!
I noticed that in lines 9, 11, and 13, "path operation" is translated as "경로 작업." Therefore, please change any instance of "경로 작동" to "경로 작업" for consistency.
| 이유는 기본적으로, FastAPI가 내부의 모든 항목을 검사하고 JSON으로 직렬화할 수 있는지 확인하기 때문입니다. 이는 사용자 안내서에서 설명된 [JSON 호환 가능 인코더](../tutorial/encoder.md){.internal-link target=_blank}를 사용하는 방식과 동일합니다. 이를 통해 데이터베이스 모델과 같은 **임의의 객체**를 반환할 수 있습니다. | ||
| 하지만 반환하는 내용이 **JSON으로 직렬화 가능**하다고 확신하는 경우, 해당 내용을 응답 클래스에 직접 전달할 수 있으며, FastAPI가 반환 내용을 `jsonable_encoder`를 통해 처리한 뒤 응답 클래스에 전달하는 추가적인 시간을 피할 수 있습니다. |
timothy-jeongFeb 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In my opinion, translating "overhead" simply as "추가적인 시간" is a somewhat limited interpretation. Generally, "overhead" doesn't refer solely to time but to the extra processing cost (e.g., time, memory, computation, etc.) incurred when performing a particular task or process.
Currently, there isn't an established translation for "overhead" in the Korean version of the documentation. Moreover, inthe German translation of the FastAPI benchmarks document—which is one of the most frequently referenced sources for this term—"overhead" is left unchanged. Considering these examples, it might be best for us to use "overhead" as is in our translation, to avoid any confusion and to convey the original meaning accurately.
Therefore, instead of translating "overhead" as "추가적인 시간," it's preferable to leave it as "오버헤드."
| **FastAPI**에서 HTML 응답을 직접 반환하려면 `HTMLResponse`를 사용하세요. | ||
| * `HTMLResponse`를 가져옵니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since "import" is aPython-specific keyword, retaining it as "임포트" preserves its intended meaning. I recommend keeping it as is.
Other Korean translated documents, such asbody-fields andbody-nested-models, directly translate the term "import" as "임포트."
this review include line 25 and 55
timothy-jeong commentedFeb 7, 2025
Great Job! |
📝 Docs preview for commitdef30ee at:https://a324b2c0.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commita3f9407 at:https://9f4ce66f.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commite26a9b0 at:https://5e4f1acc.fastapitiangolo.pages.dev Modified Pages |
| **FastAPI**에서 HTML 응답을 직접 반환하려면 `HTMLResponse`를 사용하세요. | ||
| * `HTMLResponse`를 임포트합니. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| *`HTMLResponse`를임포트합니. | |
| *`HTMLResponse`를임포트합니다. |
minor typo
📝 Docs preview for commit8fcde30 at:https://4014a114.fastapitiangolo.pages.dev Modified Pages |
timothy-jeong left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 🚀
yes0ng left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great translation! I have left a few review comments. Please take a look :)
* It would be better if you could mark the resolved comments as "resolved" for easier review.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
Co-authored-by: Lee Yesong (이예송) <yesong50@gmail.com>
📝 Docs preview for commit4f0aa6b at:https://bc8729ad.fastapitiangolo.pages.dev Modified Pages |
yes0ng left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 🔥
030012b intofastapi:masterUh oh!
There was an error while loading.Please reload this page.
alejsdev commentedFeb 15, 2025
Nice! Thank you so much for your contribution@11kkw 🚀 |
Uh oh!
There was an error while loading.Please reload this page.
내용
이 PR은
docs/ko/docs/advanced/custom-response.md파일에 대한 한국어 번역을 추가합니다. FastAPI 프로젝트에 두 번째로 기여하는 PR이며, 공식 문서를 기반으로 번역을 완료했습니다.참고 사항
번역 기준
작업 이력
🌐 Add Korean translation for docs/ko/docs/advanced/custom-response.md기여 메시지
이 PR은 저의 두 번째 오픈소스 기여입니다. 번역 스타일이나 프로세스에서 부족한 점이 있다면 적극적으로 피드백을 반영하겠습니다.
검토 요청