Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
📝 Change the word "unwrap" to "unpack" indocs/en/docs/tutorial/extra-models.md#13061
Merged
tiangolo merged 5 commits intofastapi:masterfromJan 30, 2025
Merged
Conversation
While 'unwrap' (or 'unwrapping') is a Pydantic-specific convention, its usage in the documentation might lead to confusion. The document mentions 'unwrap' with the prefix 'Python', which could incorrectly imply that 'unwrap' is official Python terminology.The behavior of 'unwrap' described in the tutorial/extra-models document aligns with the "dictionary unpacking" feature in Python dictionary displays (https://docs.python.org/3/reference/expressions.html#dictionary-displays).Therefore, if the intended behavior is indeed Python's dictionary unpacking, I suggest replacing 'unwrap' with 'unpack' for clarity and consistency with official Python terminology.
Contributor
📝 Docs preview for commite25c443 at:https://0748e877.fastapitiangolo.pages.dev Modified Pages |
hard-coders approved these changesDec 12, 2024
Contributor
hard-coders left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sounds reasonable.
timothy-jeong added a commit to timothy-jeong/fastapi that referenced this pull requestDec 12, 2024
다음과 같이 번역하였습니다.- unwrap -> 언랩(unwrap)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- unwraping -> 언래핑(unwrapping)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- type annotation -> 타입주석(type annotation)- argument value -> 인자 값(argument value)
timothy-jeong added a commit to timothy-jeong/fastapi that referenced this pull requestDec 12, 2024
다음과 같이 번역하였습니다.- unwrap -> 언랩(unwrap)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- unwraping -> 언래핑(unwrapping)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- type annotation -> 타입주석(type annotation)- argument value -> 인자 값(argument value)
Contributor
📝 Docs preview for commit0c35135 at:https://ce28ecff.fastapitiangolo.pages.dev Modified Pages |
svlandeg approved these changesDec 26, 2024
Member
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense to me!
Contributor
📝 Docs preview for commit9d977fe at:https://963b8c36.fastapitiangolo.pages.dev Modified Pages |
Contributor
📝 Docs preview for commitaa6f6b2 at:https://c8fd93cf.fastapitiangolo.pages.dev Modified Pages |
Contributor
📝 Docs preview for commit9317543 at:https://c61e6ad6.fastapitiangolo.pages.dev Modified Pages |
docs/en/docs/tutorial/extra-models.mdtiangolo approved these changesJan 30, 2025
Member
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense, thanks! ☕
83ab6ac intofastapi:master 50 checks passed
Uh oh!
There was an error while loading.Please reload this page.
timothy-jeong added a commit to timothy-jeong/fastapi that referenced this pull requestFeb 20, 2025
다음과 같이 번역하였습니다.- unwrap -> 언랩(unwrap)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- unwraping -> 언래핑(unwrapping)fastapi#13061 의 accept 여부에 따라 번역 변경 예정- type annotation -> 타입주석(type annotation)- argument value -> 인자 값(argument value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While 'unwrap' (or 'unwrapping') is a Pydantic-specific convention, its usage in the documentation might lead to confusion. The document mentions 'unwrap' with the prefix 'Python', which could incorrectly imply that 'unwrap' is official Python terminology.
The behavior of 'unwrap' described in the tutorial/extra-models document aligns with the "dictionary unpacking" feature in Python dictionary displays (https://docs.python.org/3/reference/expressions.html#dictionary-displays).
Therefore, if the intended behavior is indeed Python's dictionary unpacking, I suggest replacing 'unwrap' with 'unpack' for clarity and consistency with official Python terminology.