Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

🌐 Add Korean translation fordocs/ko/docs/advanced/testing-dependencies.md#12992

Merged
alejsdev merged 5 commits intofastapi:masterfrom
Limsunoh:features/ko-advanced-testing-dependencies
Nov 27, 2024
Merged

🌐 Add Korean translation fordocs/ko/docs/advanced/testing-dependencies.md#12992
alejsdev merged 5 commits intofastapi:masterfrom
Limsunoh:features/ko-advanced-testing-dependencies

Conversation

@Limsunoh
Copy link
Contributor

Add translation to docs/ko/docs/advanced/testing-dependencies.md

@github-actionsgithub-actionsbot added the lang-allTranslations labelNov 26, 2024
@github-actions
Copy link
Contributor

@alejsdevalejsdev added awaiting-review lang-koKorean translations labelsNov 26, 2024

제공자는 요청당 요금을 부과할 수 있으며, 테스트를 위해 고정된 모의 사용자가 있는 경우보다 호출하는 데 시간이 더 걸릴 수 있습니다.

외부 제공자를 한 번 테스트하는 것은 필요하지만, 실행되는 모든 테스트마다 호출할 필요는 없습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's okay, but it would be better to reveal the nuance of "want" more clearly.

Limsunoh reacted with heart emoji
Copy link
ContributorAuthor

@LimsunohLimsunohNov 27, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How about rephrasing it like this?


외부 제공자를 한 번 테스트하는 것은 필요하지만, 실행되는 모든 테스트마다 호출할 필요는 없습니다.

이 경우 해당 공급자를 호출하는 종속성을 재정의하고 테스트에 대해서만 모의 사용자를 반환하는 사용자 지정 종속성을 사용할 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

override; "재정의"도 좋지만 계속해서 "오버라이드"를 사용하므로 여기서도 따르면 좋을거 같습니다.

Limsunoh reacted with heart emoji
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Copy link
Contributor

@kwang1215kwang1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM !! 🔥

Limsunoh reacted with heart emoji
Copy link
Contributor

@kim-sangahkim-sangah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Limsunoh reacted with heart emoji
Copy link
Contributor

@hard-codershard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

Limsunoh reacted with heart emoji
@alejsdevalejsdev merged commitd75b81c intofastapi:masterNov 27, 2024
@alejsdev
Copy link
Member

Thanks for your work!@Limsunoh 🙏
And thanks to everyone for the reviews. ✨

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull requestJan 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

3 more reviewers

@hard-codershard-codershard-coders approved these changes

@kwang1215kwang1215kwang1215 approved these changes

@kim-sangahkim-sangahkim-sangah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-koKorean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Limsunoh@alejsdev@hard-coders@kwang1215@kim-sangah

Comments


[8]ページ先頭

©2009-2026 Movatter.jp