Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

📝 Remove mention of Celery in the project generators#12742

Merged
tiangolo merged 2 commits intofastapi:masterfrom
david-caro:remove_celery_example_mention
Nov 10, 2024
Merged

📝 Remove mention of Celery in the project generators#12742
tiangolo merged 2 commits intofastapi:masterfrom
david-caro:remove_celery_example_mention

Conversation

@david-caro
Copy link
Contributor

@david-carodavid-caro commentedNov 1, 2024•
edited
Loading

Infull-stack-fastapi-template!694celery was removed from the template project, it makes no sense anymore mentioning in the docs that is an example on how to use celery.

mycaule and svlandeg reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the docsDocumentation about how to use FastAPI labelNov 1, 2024
@david-caro
Copy link
ContributorAuthor

Being a simple removal of text, I bundled all the pages together, but if it's easier to review them one-by-one let me know and I'll split the change.

@github-actions
Copy link
Contributor

Infastapi/full-stack-fastapi-template#694celery was removed from the template project, it makes no senseanymore mentioning in the docs that is an example on how to usecelery.Signed-off-by: David Caro <me@dcaro.es>
@david-carodavid-caroforce-pushed theremove_celery_example_mention branch fromdc46d1a toa3a6996CompareNovember 1, 2024 09:26
@github-actions
Copy link
Contributor

@alejsdevalejsdev changed the title🌐 Remove mention of celery being in the project generators📝 Remove mention of celery being in the project generatorsNov 1, 2024
Copy link
Member

@svlandegsvlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me - thanks for being so thorough through all the languages! In a case like this, it's definitely fine to keep all the changes in the same PR, as they're highly related.

I'll pass this on internally to Tiangolo for a final review 🙏

david-caro reacted with thumbs up emoji
@alejsdevalejsdev changed the title📝 Remove mention of celery being in the project generators📝 Remove mention of Celery being in the project generatorsNov 9, 2024
@alejsdevalejsdev changed the title📝 Remove mention of Celery being in the project generators📝 Remove mention of Celery in the project generatorsNov 9, 2024
@github-actions
Copy link
Contributor

📝 Docs preview for commit50fc58a at:https://88def53c.fastapitiangolo.pages.dev

Modified Pages

Copy link
Member

@tiangolotiangolo left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, makes sense, thanks@david-caro! 🍰 ☕

And thanks for the reviews@svlandeg and@alejsdev 🙇

@tiangolotiangolo merged commitbfaf4c3 intofastapi:masterNov 10, 2024
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull requestJan 23, 2025
Signed-off-by: David Caro <me@dcaro.es>Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tiangolotiangolotiangolo approved these changes

@svlandegsvlandegsvlandeg approved these changes

@alejsdevalejsdevalejsdev approved these changes

Assignees

No one assigned

Labels

docsDocumentation about how to use FastAPI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david-caro@tiangolo@svlandeg@alejsdev

Comments

[8]ページ先頭
©2009-2026 Movatter.jp