Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🌐 Add Korean translation fordocs/ko/docs/advanced/wsgi.md#12659

Merged
alejsdev merged 9 commits intofastapi:masterfrom
Limsunoh:features/ko-advanced-wsgi
Oct 31, 2024
Merged

🌐 Add Korean translation fordocs/ko/docs/advanced/wsgi.md#12659
alejsdev merged 9 commits intofastapi:masterfrom
Limsunoh:features/ko-advanced-wsgi

Conversation

@Limsunoh
Copy link
Contributor

No description provided.

@github-actionsgithub-actionsbot added the lang-allTranslations labelOct 28, 2024
@github-actions
Copy link
Contributor

@alejsdevalejsdev added awaiting-review lang-koKorean translations labelsOct 28, 2024
@alejsdevalejsdev changed the titleAdd translation to docs/ko/docs/advanced/wsgi.md🌐 Add Korean Translation fordocs/ko/docs/advanced/wsgi.mdOct 28, 2024
@alejsdevalejsdev changed the title🌐 Add Korean Translation fordocs/ko/docs/advanced/wsgi.md🌐 Add Korean translation fordocs/ko/docs/advanced/wsgi.mdOct 28, 2024
Copy link
Contributor

@hard-codershard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good job! However, some points need improvement. I believe reading others' translations will help you.

Copy link

@sodaMelonsodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hi@Limsunoh i left some comment to read better.
번역에서는 기본적으로 ~습니다 를 쓰게되어있어서
어투만 교정했습니다.
나머지는@hard-coders 님 코멘트를 확인하세요!

Limsunoh reacted with thumbs up emojiLimsunoh reacted with laugh emojiLimsunoh reacted with heart emoji
Limsunohand others added2 commitsOctober 31, 2024 16:57
Co-authored-by: hy.lee <rurouni24@gmail.com>
Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions
Copy link
Contributor

Limsunohand others added3 commitsOctober 31, 2024 17:09
Co-authored-by: hy.lee <rurouni24@gmail.com>
Co-authored-by: hy.lee <rurouni24@gmail.com>
"Thank you for explaining it so wellCo-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Copy link

@sodaMelonsodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Limsunoh reacted with heart emoji
@github-actions
Copy link
Contributor

Copy link
Contributor

@hard-codershard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

Limsunoh reacted with heart emoji
@alejsdevalejsdevenabled auto-merge (squash)October 31, 2024 18:56
@alejsdevalejsdev merged commit14b087c intofastapi:masterOct 31, 2024
@alejsdev
Copy link
Member

Nice, thank you!@Limsunoh 🥳
And thanks for the reviews@hard-coders@sodaMelon 🎉

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull requestJan 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@hard-codershard-codershard-coders approved these changes

@sodaMelonsodaMelonsodaMelon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2lang-allTranslationslang-koKorean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Limsunoh@alejsdev@hard-coders@sodaMelon

Comments

[8]ページ先頭
©2009-2026 Movatter.jp