Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Comments
📝 Update comma indocs/en/docs/async.md#12062
Merged
tiangolo merged 2 commits intofastapi:masterfromAug 28, 2024
Merged
Conversation
Contributor
📝 Docs preview for commit2ce30c9 at:https://6e853707.fastapitiangolo.pages.dev Modified Pages |
Member
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the contribution! I agree that we could make this sentence more readable. I would however suggest to only insert the first comma, so that we don't have a comma followed immediately by "and". The "it can start and it wil end" belongs together in a subsentence, IMO.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Contributor
📝 Docs preview for commitac1efc9 at:https://ca5f4a09.fastapitiangolo.pages.dev Modified Pages |
svlandeg approved these changesAug 26, 2024
docs/en/docs/async.mddocs/en/docs/async.mdMember
tiangolo commentedAug 28, 2024
Cool, thanks! 🤓 |
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: Alec Gillis <alecgillis@quorum.us>Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: Alec Gillis <alecgillis@quorum.us>Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: Alec Gillis <alecgillis@quorum.us>Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull requestJan 23, 2025
Co-authored-by: Alec Gillis <alecgillis@quorum.us>Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add commas to a series in a sentence under the Coroutines section to enhance readability.