Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
📝 Updatedocs/en/docs/tutorial/dependencies/dependencies-with-yield.md#12045
Conversation
docs/en/docs/tutorial/dependencies/dependencies-with-yield.mddocs/en/docs/tutorial/dependencies/dependencies-with-yield.mddocs/en/docs/tutorial/dependencies/dependencies-with-yield.md📝 Docs preview for commit81bc206 at:https://f04d7eae.fastapitiangolo.pages.dev Modified Pages |
svlandeg left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi, thanks for your contribution! 🙏
I'm not sure I fully understand the suggestion here, and what "but before sending it" actually means. You mention that this has changed after FastAPI 0.106.0, can you share a link to the relevant commit/PR/change log?
[UPDATE]: Ah, found it, this is probably related to#10831?
svlandeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep I think this looks good, thanks again! 🙏
📝 Docs preview for commitf439898 at:https://e899cbec.fastapitiangolo.pages.dev Modified Pages |
tiangolo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep, good catch@xuvjso. thanks! 🚀 🍰
…md` (fastapi#12045)Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
After FastAPI 0.106.0, the code after yield now runs after the response is created but before it is sent to the client.