Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.7k
Merged
Conversation
hynek commentedAug 5, 2024
I'm sowwy, if I knew it would've even reach the far shores of FastAPI, I would've only soft-deprecated it. 🥺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
🔇 Ignore warning from attrs in Trio
A recent release of a attrs marked a parameter
hashas deprecated. It is used by Trio (fixed here:python-trio/trio#3054, but still unreleased). Trio is used by AnyIO's pytest plugin.This currently shows a deprecation warning that is breaking tests in FastAPI. This PR adds an ignore for that warning so tests here can keep running.