Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🐛 Fixallow_inf_nan option for Param and Body classes#11867

Merged
tiangolo merged 9 commits intofastapi:masterfrom
giunio-prc:fix/issue11580
Aug 24, 2024
Merged

🐛 Fixallow_inf_nan option for Param and Body classes#11867
tiangolo merged 9 commits intofastapi:masterfrom
giunio-prc:fix/issue11580

Conversation

@giunio-prc
Copy link
Contributor

@giunio-prcgiunio-prc commentedJul 19, 2024•
edited
Loading

adjust typo causing allow_inf_nan to be ignored during paramter enforcing

I added the test from the issue page#11580 in a separate commit

svlandeg reacted with thumbs up emoji
@giunio-prcgiunio-prc changed the titleFix/issue11580Fix/issue11580 allow_nan_inf ignored when enforcing parametersJul 19, 2024
@giunio-prcgiunio-prc changed the titleFix/issue11580 allow_nan_inf ignored when enforcing parametersFix/issue11580 allow_inf_nan ignored when enforcing parametersJul 19, 2024
@YuriiMotov
Copy link
Member

Duplicates existing PR:https://github.com/tiangolo/fastapi/pull/11579/files

giunio-prc, svlandeg, and tiangolo reacted with thumbs up emoji

@giunio-prc
Copy link
ContributorAuthor

Duplicates existing PR:https://github.com/tiangolo/fastapi/pull/11579/files

I see, but that one is missing one occurence, the problem happens for Params and Body class

@giunio-prcgiunio-prc marked this pull request as draftJuly 19, 2024 21:17
@giunio-prcgiunio-prc marked this pull request as ready for reviewJuly 21, 2024 07:19
@alejsdevalejsdev added the bugSomething isn't working labelJul 24, 2024
@svlandegsvlandeg self-assigned thisAug 19, 2024
@svlandegsvlandeg changed the titleFix/issue11580 allow_inf_nan ignored when enforcing parameters🐛 Fixallow_inf_nan options for Param and Body classesAug 19, 2024
@svlandegsvlandeg changed the title🐛 Fixallow_inf_nan options for Param and Body classes🐛 Fixallow_inf_nan option for Param and Body classesAug 19, 2024
Copy link
Member

@svlandegsvlandeg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@giunio-prc for the contribution, and@YuriiMotov for the review and link to the related PR 🙏

I can confirm that this bug occurs onmaster and should be fixed with this PR. In addition to the fix in the original PR#11579, this one also fixes a similar issue withBody, so I would prefer to merge this one and close the other. I've updated the unit tests here to include the cases from both PRs, I added parametrization and updated the PR with the latest frommaster. Thanks to@pat-lasswell as well for the original report and PR! 🎉

giunio-prc and tiangolo reacted with hooray emoji
@svlandegsvlandeg removed their assignmentAug 19, 2024
@tiangolo
Copy link
Member

Thanks for your contribution@giunio-prc! 🍰

Thanks for the extra info@YuriiMotov 🍫

And thanks for the help and tweaks@svlandeg! 🙇

This will be available in FastAPI0.112.2 released in the next hours. 🎉

giunio-prc and svlandeg reacted with hooray emoji

@tiangolotiangolo merged commit51b625e intofastapi:masterAug 24, 2024
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: svlandeg <svlandeg@github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: svlandeg <svlandeg@github.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull requestSep 12, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: svlandeg <svlandeg@github.com>
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull requestJan 23, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: svlandeg <svlandeg@github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@svlandegsvlandegsvlandeg approved these changes

+1 more reviewer

@NischalSehrawatNischalSehrawatNischalSehrawat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query fields with numeric types appear not to enforce allow_inf_nan=False, whereas gt=0, etc are enforced

6 participants

@giunio-prc@YuriiMotov@tiangolo@svlandeg@NischalSehrawat@alejsdev

Comments

[8]ページ先頭
©2009-2026 Movatter.jp