@teuneboon

Here's a workaround that I think handles your issue pretty cleanly:

@sub_sub_router.get("$")deftest():return'bar'

Why this works: the path passed to the route decorator here is actually used to build a regex.$ matches the end of a string, so"$" is basically equivalent to"", but the recently-modified router-inclusion-check just checks that the path is not empty (not that it starts with "/"). So it will not raise an error when you do the nested include. (Actually, starlette adds a$ to the path already when building the regex, but having a second$ doesn't change what matches.)

Note: this will prevent the check that the route starts with a "/" when you are done cascading your inclusions, so you'd need to take responsibility for that. But that seems like a pretty reasonable compromise given the design you are trying to achieve.

@dmontagu thanks, that should fix the issue for me.

Thanks for the help here@dmontagu ! 👏 🙇

Thanks for reporting back and closing the issue@teuneboon 👍

@teuneboon@tiangolo@dmontagu the generated swagger shows /route$ instead of /route for this approach... and calls the route that is suffixed with the dollar sign when you click "try it out". Is there a way to avoid this?

@HansBrende I'm not sure I understand what you mean. If you still have problems please create a new issue with a simple self-contained example that shows how to reproduce the error, that way we can help you.

@tiangolo I am referring to the approach suggested by dmontagu. It works, but the Open API (swagger) page displays the regex in the path and the "try it out" button calls the incorrect API path. Not sure what part of this you didn't understand, perhaps you can elaborate.

Hello there,

I had the same issue as@HansBrende regarding the generated OpenAPI schemas (also mentioned as "swagger" in his comment).

@dmontagu's answer - with"$" is just the right way. But, for those wondering about how to get the trailing$ away from the schema paths description here is what I found out.

I took the time to search for "OpenAPI" in the documentation and ended in theExtending OpenAPI chapter. I leave to you the lecture of the chapter but if we take the final example - as of today:

fromfastapiimportFastAPIfromfastapi.openapi.utilsimportget_openapiapp=FastAPI()@app.get("/items/")asyncdefread_items():return [{"name":"Foo"}]defcustom_openapi():ifapp.openapi_schema:returnapp.openapi_schemaopenapi_schema=get_openapi(title="Custom title",version="2.5.0",description="This is a very custom OpenAPI schema",routes=app.routes,    )openapi_schema["info"]["x-logo"]= {"url":"https://fastapi.tiangolo.com/img/logo-margin/logo-teal.png"    }app.openapi_schema=openapi_schemareturnapp.openapi_schemaapp.openapi=custom_openapi

A simple change of thecustom_openapi() function as follow fix our issue:

defcustom_openapi():ifapp.openapi_schema:returnapp.openapi_schemaopenapi_schema=get_openapi(title="Custom title",version="2.5.0",description="This is a very custom OpenAPI schema",routes=app.routes,    )openapi_schema["info"]["x-logo"]= {"url":"https://fastapi.tiangolo.com/img/logo-margin/logo-teal.png"    }## Change starts here.forpathin {xforxinapp.openapi_schema["paths"]ifx.endswith("$")}:app.openapi_schema["paths"][path[:-1]]=app.openapi_schema["paths"][path]delapp.openapi_schema["paths"][path]### Change ends here.app.openapi_schema=openapi_schemareturnapp.openapi_schema

I suppose that this is the right way but@tiangolo may correct me here.

Thanks for everything@dmontagu@tiangolo.

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

@tiangolo I wrote under answer a year ago, so Im writing here again. The problem persists, and adding$ sign (as per@dmontagu) does not solve the problem, API route is WITH$ sign, and any API without$ does not exist. Any other workaround? Or plan to fix this?

P. S. My version: 0.115.14

Code example in initial post is invalid. Simplified correct code example:

fromfastapiimportAPIRouter,FastAPIrouter=APIRouter()@router.get("")deftest():return"bar"app=FastAPI()app.include_router(router)

So, it's not about "double-nested" router, but just about router without prefix