- Notifications
You must be signed in to change notification settings - Fork298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Reorder fields in farm_log view#618
Open
paul121 wants to merge1 commit intofarmOS:2.xChoose a base branch
base:2.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I'll try to add thoughts to the forum topic so we don't split the conversation too much, but one question:
Not sure I understand, aren't all of these changes related to moving the columns around, not just the log ID? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorders the fields in the farm_log table view as described in this forum post:https://farmos.discourse.group/t/change-column-order-in-logs-view/1419?u=paul121
Before: status, ID, timestamp, log name, log type**
After: log name, log type**, timestamp, status, ID (moved to very last)
**the log type column is only displayed on the
/logs page, not/logs/{log_type]Unfortunately because this PR only changes the field order, this is blocked by this issue:https://www.drupal.org/project/farm/issues/3325911
I would like to consider removing the log ID from these table views, but I think we do need the log ID in the CSV export. We could override the CSV export to include the log ID but then then we lose the convenience of the "default views fields" in the CSV export display. If we did make this change for the log ID then this PR would not be blocked by the above issue.
What do we think?