Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(#168): remove dependency on derivative#169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jalil-salame
Copy link
Contributor

It is unmaintained and can be replaced with a small manual impl ofDebug.

Closes#168

I also fixed some clippy suggestions while I was at it.

keith-hall reacted with heart emoji
Clippy was complaining about redundant field names, so I fixed it.
@jalil-salame
Copy link
ContributorAuthor

rust-analyzer makes this kind of transformation easy:

  1. A code action on an enum struct allows you to extract the anonymous struct into a named struct.
  2. A code action on the#[derive(Debug)] macro lets you turn in into a manual impl of theDebug trait.
keith-hall reacted with hooray emoji

Copy link
Contributor

@robinstrobinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

jalil-salame reacted with hooray emoji
@jalil-salame
Copy link
ContributorAuthor

Looks like a snapshot changed, I'll try to fix it

It is unmaintained and can be replaced with a small manual impl of`Debug`.
Copy link
Contributor

@keith-hallkeith-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! We can ignore the code coverage warnings, actually itis covered by example tests.

@keith-hallkeith-hall merged commit34c7bb3 intofancy-regex:mainJul 8, 2025
7 of 9 checks passed
@jalil-salamejalil-salame deleted the push-szutvmxzkkku branchJuly 8, 2025 20:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@keith-hallkeith-hallkeith-hall approved these changes

@robinstrobinstAwaiting requested review from robinst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

derivative is unmaintained
3 participants
@jalil-salame@robinst@keith-hall
[8]ページ先頭
©2009-2025 Movatter.jp