Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve toy compile output on wrapped regexes#159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

keith-hall
Copy link
Contributor

When a regex pattern is easy and fancy-regex is just used as a wrapper, thetoy compile output was showing the debug output of the regex-automata compilation of the pattern instead of just the plain regex pattern string. This change fixes that, and makes it easier to understand thetoy compile output in such situations.

@keith-hall
Copy link
ContributorAuthor

codecov isn't taking tests in examples into account it seems. I don't think it is worth duplicating some tests into other files just to make these code coverage failures go away, but let me know if you disagree...

Copy link
Contributor

@robinstrobinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Yeah, ignore the coverage.

keith-hall reacted with thumbs up emoji
@keith-hallkeith-hall merged commit84f3512 intofancy-regex:mainApr 26, 2025
7 of 9 checks passed
@keith-hallkeith-hall deleted the compile_output_wrapped_regex branchApril 26, 2025 02:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@robinstrobinstrobinst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@keith-hall@robinst

[8]ページ先頭

©2009-2025 Movatter.jp