Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork41
Improve toy compile output on wrapped regexes#159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Improve toy compile output on wrapped regexes#159
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov isn't taking tests in examples into account it seems. I don't think it is worth duplicating some tests into other files just to make these code coverage failures go away, but let me know if you disagree... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Yeah, ignore the coverage.
84f3512
intofancy-regex:mainUh oh!
There was an error while loading.Please reload this page.
When a regex pattern is easy and fancy-regex is just used as a wrapper, the
toy compile
output was showing the debug output of the regex-automata compilation of the pattern instead of just the plain regex pattern string. This change fixes that, and makes it easier to understand thetoy compile
output in such situations.