Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix toy example#152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
keith-hall merged 9 commits intofancy-regex:mainfromforkeith:fix_toy_example
Mar 12, 2025
Merged

Conversation

keith-hall
Copy link
Contributor

Thetoy example had a number of shortcomings:

  • the debug output was too verbose - it showed the PikeVM debug output instead of the regex pattern for example, making the graph unreadably big
  • it panicked with regex patterns which include backrefs etc. due to the analyzed expression tree missing instructions for the 0th group

This PR fixes those problems and adds some tests which verify the output from thetoy example, and runs those tests in CI.

Copy link
Contributor

@robinstrobinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@keith-hallkeith-hall merged commitd1ccf2b intofancy-regex:mainMar 12, 2025
8 of 9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@robinstrobinstrobinst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@keith-hall@robinst

[8]ページ先頭

©2009-2025 Movatter.jp