Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(docs): updateplugins_hostinfo config file comment.#3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
poiana merged 3 commits intomasterfromchore/update_hostinfo_comment
Jan 16, 2025

Conversation

FedeDP
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

[APPROVALNOTIFIER] This PR isAPPROVED

This pull-request has been approved by:FedeDP

The full list of commands accepted by this bot can be foundhere.

The pull request process is describedhere

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@FedeDP
Copy link
ContributorAuthor

/milestone 0.40.0

@poianapoiana added this to the0.40.0 milestoneJan 15, 2025
falco.yaml Outdated
# dropping the `hostPath` volume requirement for them.
# that DO NOT generate raw events from the libscap event table
# or for plugins that DO NOT parse raw events generated by drivers,
# effectively dropping the `hostPath` volume requirement for them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think there should be a link to the "hostPath volume requirement".

Because, as a user, reading this, I would search in this file for more information and since there's no other mention of hostPath, would have to start digging through the doc (or maybe even the code) for what that might be.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are right, will put a link to the charts section!

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done :)

…emplate.Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@leogrleogr requested a review fromsgaistJanuary 16, 2025 08:22
leogr
leogr previously approved these changesJan 16, 2025
Copy link
Contributor

@sgaistsgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Much better !

One last question: AFAICS the pod template does not make theproc-fs hostPath optional so it is a bit confusing. Did I miss something ?

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
ContributorAuthor

FedeDP commentedJan 16, 2025•
edited
Loading

Did I miss something ?

@sgaist you did not miss anything! The next chart version will make it optional with a flag :) cc@alacuku

@sgaist
Copy link
Contributor

Did I miss something ?

@sgaist you did not miss anything! The next chart version will make it optional with a flag :) cc@alacuku

So my helm-fu is still good :-)

In that case, should this change be merged after the one on the chart ?

FedeDP reacted with laugh emoji

@FedeDP
Copy link
ContributorAuthor

In that case, should this change be merged after the one on the chart ?

Unfortunately, the chart gets updated very very near the release, and it can even get released a couple of days after the release :(
Also, this change was already merged, we are only fixing the comment right now!

@sgaist
Copy link
Contributor

In that case, should this change be merged after the one on the chart ?

Unfortunately, the chart gets updated very very near the release, and it can even get released a couple of days after the release :( Also, this change was already merged, we are only fixing the comment right now!

Understood
At least we have this ticket in case people are wondering for the mismatch.

@poianapoiana merged commit7339363 intomasterJan 16, 2025
33 checks passed
@poianapoiana deleted the chore/update_hostinfo_comment branchJanuary 16, 2025 09:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sgaistsgaistsgaist approved these changes

@leogrleogrleogr approved these changes

@Andreagit97Andreagit97Awaiting requested review from Andreagit97

@KaizheKaizheAwaiting requested review from Kaizhe

Assignees

@sgaistsgaist

@leogrleogr

Projects
Archived in project
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.

4 participants
@FedeDP@poiana@sgaist@leogr
[8]ページ先頭
©2009-2025 Movatter.jp