Commite794d06

shapovalov

authored and

facebook-github-bot

committed

Improving RayBundle docstrings

Summary: This changes only documentation. We want to be explicit that ray directions are not normalised (nor assumed to be normalised) but their magnitude is used.Reviewed By: nikhilaraviDifferential Revision: D29845210fbshipit-source-id: b81fb3da13a42ad20e8721ed5271fd4f3d8f5acb

1 parent1872e02 commite794d06Copy full SHA for e794d06

File tree

1 file changed

-0

lines changed

pytorch3d/renderer/implicit
- utils.py

1 file changed

-0

lines changed

`‎pytorch3d/renderer/implicit/utils.py‎`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@ class RayBundle(NamedTuple):`
`14`	`14`	RayBundle parametrizes points along projection rays by storing ray `origins`,
`15`	`15`	`directions` vectors and `lengths` at which the ray-points are sampled.
`16`	`16`	Furthermore, the xy-locations (`xys`) of the ray pixels are stored as well.
	`17`	+ Note that `directions` don't have to be normalized; they define unit vectors
	`18`	`+ in the respective 1D coordinate systems; see documentation for`
	`19`	+ :func:`ray_bundle_to_ray_points` for the conversion formula.
`17`	`20`	`"""`
`18`	`21`
`19`	`22`	`origins:torch.Tensor`
`@@ -36,6 +39,8 @@ def ray_bundle_to_ray_points(ray_bundle: RayBundle) -> torch.Tensor:`
`36`	`39`	`+ ray_bundle.directions[i, :] * ray_bundle.lengths[i, j]`
`37`	`40`	`)`
`38`	`41`	```
	`42`	`+ Note that both the directions and magnitudes of the vectors in`
	`43`	+ `ray_bundle.directions` matter.
`39`	`44`
`40`	`45`	`Args:`
`41`	`46`	ray_bundle: A `RayBundle` object with fields:
`@@ -70,6 +75,8 @@ def ray_bundle_variables_to_ray_points(`
`70`	`75`	`+ rays_directions[i, :] * rays_lengths[i, j]`
`71`	`76`	`)`
`72`	`77`	```
	`78`	`+ Note that both the directions and magnitudes of the vectors in`
	`79`	+ `rays_directions` matter.
`73`	`80`
`74`	`81`	`Args:`
`75`	`82`	rays_origins: A tensor of shape `(..., 3)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite794d06

File tree

1 file changed

1 file changed

`‎pytorch3d/renderer/implicit/utils.py‎`

0 commit comments