Commit5053142

bottler

authored and

facebook-github-bot

committed

typing for unproject_points

Summary: Fix the base class annotation for unproject_points.Reviewed By: patricklabatutDifferential Revision: D33281586fbshipit-source-id: 1c34e8c4b30b359fcb9307507bc778ad3fecf290

1 parent67778ca commit5053142Copy full SHA for 5053142

File tree

2 files changed

-2

lines changed

pytorch3d/renderer
- cameras.py
- implicit
  - raysampling.py

2 files changed

-2

lines changed

`‎pytorch3d/renderer/cameras.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ def get_projection_transform(self):`
`98`	`98`	`"""`
`99`	`99`	`raiseNotImplementedError()`
`100`	`100`
`101`		`-defunproject_points(self):`
	`101`	`+defunproject_points(self,xy_depth:torch.Tensor,**kwargs):`
`102`	`102`	`"""`
`103`	`103`	`Transform input points from camera coodinates (NDC or screen)`
`104`	`104`	`to the world / camera coordinates.`

`‎pytorch3d/renderer/implicit/raysampling.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ def _xy_to_ray_bundle(`
`549`	`549`	`)`
`550`	`550`
`551`	`551`	`# unproject the points`
`552`		`-unprojected=cameras.unproject_points(to_unproject,from_ndc=True)# pyre-ignore`
	`552`	`+unprojected=cameras.unproject_points(to_unproject,from_ndc=True)`
`553`	`553`
`554`	`554`	`# split the two planes back`
`555`	`555`	`rays_plane_1_world=unprojected[:, :n_rays_per_image]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5053142

File tree

2 files changed

2 files changed

`‎pytorch3d/renderer/cameras.py‎`

`‎pytorch3d/renderer/implicit/raysampling.py‎`

0 commit comments