Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Report errors if location provider fails#4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
captbaritone wants to merge1 commit intomainfromlocate
Closed

Conversation

captbaritone
Copy link
Contributor

Setting up the location provider in the most recent version of the VSCode extension is nearly impossible because if you don't do it perfectly (define the script using the right relative path, know which CWD the script will run in, use the right argument, parse it correctly, return the location in the correct format...) it simply fails silently with no hint as to what went worng.

Adding this logging will at least enable folks to debug what's happening in the Relay LSP Output panel, if they set the log level correctly.

The other option would be to simply return an error if there is a location provider provided and it errors trying to derive location info. I'm not sure how fallible we except these to be (I happen to know our Hack version has known issues where certain fields/types can't really get resolved).

Test Plan:

Screen.Recording.2024-01-18.at.10.16.18.PM.mov

tobias-tengler reacted with heart emoji
@orta
Copy link
Contributor

Thanks, came to see if something like this existing in the source code!

@facebook-github-bot
Copy link
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diffon Phabricator.

@facebook-github-bot
Copy link
Contributor

@captbaritone merged this pull request inbbddbf3.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@captbaritone@orta@facebook-github-bot

[8]ページ先頭

©2009-2025 Movatter.jp