- Notifications
You must be signed in to change notification settings - Fork25k
Gate requestBody processing behind BuildConfig.DEBUG#54920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
+13 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Summary:facebook#54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. Infacebook#54881, users report failing requests attributed to this code path when performing image uploads.Functionally revert this change, as this breaks runtime behaviour.Changelog: [Internal]Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary dataReviewed By: vzaidmanDifferential Revision: D89373824
Summary:Gates `requestBody` handling for `reportRequestStart` on Android with `BuildConfig.DEBUG`. This is an appropriate optimisation as we do not use body previews outside of CDP debugging, aligning with the same conditional behaviour on iOS.I'd like to also pick this change for 0.83.1, with D89373824, for additional safety.**Other notes**Gating by `BuildConfig` isn't done elsewhere in this file, as other potentially expensive behaviour is gated lower down by both `REACT_NATIVE_DEBUGGER_ENABLED` and the `Network.enable` CDP message. This was the only remaining gap with the iOS implementation.Changelog: [Internal]Reviewed By: vzaidmanDifferential Revision: D89377163
This pull request has been merged in33005a4. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exportedMergedThis PR has been merged. meta-exportedp: FacebookPartner: Facebook Partner
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gates
requestBodyhandling forreportRequestStarton Android withBuildConfig.DEBUG. This is an appropriate optimisation as we do not use body previews outside of CDP debugging, aligning with the same conditional behaviour on iOS.I'd like to also pick this change for 0.83.1, with D89373824, for additional safety.
Other notes
Gating by
BuildConfigisn't done elsewhere in this file, as other potentially expensive behaviour is gated lower down by bothREACT_NATIVE_DEBUGGER_ENABLEDand theNetwork.enableCDP message. This was the only remaining gap with the iOS implementation.Changelog: [Internal]
Reviewed By: vzaidman
Differential Revision: D89377163