Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove <React.unstable_ConcurrentMode /> element type#15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@acdlite
Copy link
Collaborator

@acdliteacdlite commentedApr 29, 2019
edited
Loading

We decided to remove this because we're not convinced it's practical to opt a particular subtree into Concurrent Mode without opting in the entire root. The recommendation is to usecreateRoot instead.

MuYunyun, ashnur, and rileyjshaw reacted with eyes emoji
@NE-SmallTown
Copy link
Contributor

NE-SmallTown commentedMay 1, 2019
edited
Loading

Could we preserve this(concurrent mode) and just allow it be used in root? By the way, could you share more info about why it's impossible to be used in a particular subtree without opting in the entire root?

@acdlite
Copy link
CollaboratorAuthor

@NE-SmallTown It's not impossible, but it creates weird edge cases that we'd prefer not to support, given that we haven't found a compelling enough use case for it.

NE-SmallTown reacted with heart emoji

Use createSyncRoot instead.
@acdliteacdliteforce-pushed theremove-concurrent-mode-element-type branch from24c6edf toe34a55fCompareMay 13, 2019 22:33
@acdliteacdlite merged commit83fc258 intofacebook:masterMay 13, 2019
@gaearongaearon mentioned this pull requestJul 30, 2019
@VinSpee
Copy link

we're not convinced it's practical to opt a particular subtree into Concurrent Mode without opting in the entire root

Hi! at@tedconf we use many roots, and are slowly migrating things to be concurrent-safe. For us, it's not practical to upgrade every single root tocreateRoot rapidly, it's far easier for us to ensure that certain components will work and then eventually move thatConcurrentMode boundary higher and higher up each tree until eventually they can be replaced with acreateRoot.

Is this something you'd considered?

@sebmarkbage
Copy link
Collaborator

sebmarkbage commentedAug 27, 2019
edited
Loading

@VinSpee, yea that use case was the original purpose but it turns out that the semantics doesn’t quite make sense in the mixed world. We can’t guarantee exactly how the changes in the top of the root flows into the subtree. Similarly if something suspends inside the subtree, that can trigger a boundary in the outside. So it adds a lot of complexity that you are probably better equipped to handle in user space.

However you can still add StrictMode in subtrees to get warnings and some dev mode things that get your ready for concurrent mode.

There is also the createSyncRoot api that has some of the same semantics as concurrent mode.

Then once you have one root that is complete you can just upgrade that one.

This was referencedMar 10, 2020
@gaearongaearon mentioned this pull requestMar 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sebmarkbagesebmarkbagesebmarkbage approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acdlite@NE-SmallTown@VinSpee@sebmarkbage@facebook-github-bot

[8]ページ先頭

©2009-2025 Movatter.jp