- Notifications
You must be signed in to change notification settings - Fork452
[test] Import changes to port sharedmem tables into OCaml 5.2 domain-based parallelism#926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
grievejia wants to merge14 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
... and also fix some script shebangs
Since some of these tests are parallel themselves, I don't want to putto much load on the system, which might (?) artificially degrade themeasurements.
Contributor
facebook-github-bot commentedSep 28, 2024
@grievejia has imported this pull request. If you are a Meta employee, you can view this diffon Phabricator. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folks at Tarides have already experimented with porting Pyre's multi-processing sharedmem library into relying on OCaml5's domain-based multi-threading mechanism.
I'm creating this PR so we have an easy way of importing the changes into Meta's internal repository. Please do not accept this change -- it's likely to require some cleanup work. But we should start experimenting & benchmarking with it and see how much perf gain we could reap (and hopefully report the numbers back to the original author).