Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils"#15095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SimenB merged 6 commits intojestjs:mainfromconnectdotz:snapshot-utils
May 29, 2024

Conversation

@connectdotz
Copy link
Contributor

Summary

This PR addresses issue#15036.

Changes include:

  • Moved the specific functions mentioned in the issue, along with any supporting functions and those sharing the same locally defined private constants. This targeted approach minimizes changes and avoids potential circular references, rather than moving the entire utils.ts file.

  • Fixed a few end-to-end (e2e) unit tests that causedyarn test to fail during development. The failures were specifically related to the generation of empty .watchmanconfig files in these tests. With watchman version2024.05.06.00 on mac, I encountered JSON parsing errors when the config file was blank (rather than containing{} or[]). This fix is limited to the occurrences encountered to keep the scope of changes manageable.

Test plan

should not break existing tests

@linux-foundation-easycla
Copy link

linux-foundation-easyclabot commentedMay 29, 2024•
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlifybot commentedMay 29, 2024•
edited
Loading

✅ Deploy Preview forjestjs ready!

NameLink
🔨 Latest commit5ae8cfd
🔍 Latest deploy loghttps://app.netlify.com/sites/jestjs/deploys/6656c96a46e5a10008037e00
😎 Deploy Previewhttps://deploy-preview-15095--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@connectdotzconnectdotz changed the titlesplit some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils"feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils"May 29, 2024
Copy link
Member

@SimenBSimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@SimenBSimenB merged commit7a2ccc2 intojestjs:mainMay 29, 2024
@connectdotzconnectdotz deleted the snapshot-utils branchMay 29, 2024 18:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend usingStackOverflow or ourdiscord channel for questions.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@SimenBSimenBSimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Restore Access to Utility Functions in "jest-snapshot/utils" for Continued Tooling Support

2 participants

@connectdotz@SimenB
[8]ページ先頭
©2009-2025 Movatter.jp