Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
feat: showcase#9967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
feat: showcase#9967
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedMar 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ [V2]
To edit notification comments on pull requests, go to yourNetlify site configuration. |
github-actionsbot commentedMar 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
⚡️ Lighthouse report for the deploy preview of this PR
|
github-actionsbot commentedMar 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Size Change: +4.94 kB (+0.29%) Total Size: 1.72 MB
ℹ️View Unchanged
|
OzakIOne commentedMar 26, 2024
Been trying to process markdown showcase page however I don't understand the logic looking at plugin page, return{type:'mdx',permalink,source:aliasedSourcePath,title:frontMatter.title??contentTitle,description:frontMatter.description??excerpt,frontMatter,unlisted,}; and awaitPromise.all(content.map(async(metadata)=>{const{permalink, source}=metadata;constrouteMetadata=createPageRouteMetadata(metadata);if(metadata.type==='mdx'){awaitcreateData(// ozaki: why dont we store this value in a const and then pass it to addRoute modules.content ?// Note that this created data path must be in sync with// metadataPath provided to mdx-loader.`${docuHash(metadata.source)}.json`,JSON.stringify(metadata,null,2),);addRoute({path:permalink,component:options.mdxPageComponent,// ozaki: how does the content is rendered in the component ?exact:true,metadata:routeMetadata,modules:{content:source,// ozaki: how does the content is a aliasedPath ?},});}else{// process things that are not mdx}}),);``` |
OzakIOne commentedMar 27, 2024
Trying to implement image insertion, let's say we have this file structure : I wonder how to resolve the image path when rendering to the component, I've made it work with the assets folder but I think its better to let preview images aside .yml files |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| constTags=useShowcaseTags(); | ||
| constTagList=Object.keys(Tags)asTagType[]; | ||
| consttagObjects=tags.map((tag)=>({tag, ...Tags[tag]})); | ||
| // Keep same order for all tags | ||
| consttagObjectsSorted=sortBy(tagObjects,(tagObject)=> | ||
| TagList.indexOf(tagObject.tag), | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The plugin should probably short the site tags on the nodejs side, this way the theme receives already-sorted tags and we don't need to run any extra runtime logic
Uh oh!
There was an error while loading.Please reload this page.
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview & tests
showcaseAll
Related issues/PRs
#6882