Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
feat(i18n): support translating through locale extensionsmyDoc.fr.md#9700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
slorber wants to merge8 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
netlifybot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ [V2]
To edit notification comments on pull requests, go to yourNetlify site configuration. |
github-actionsbot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
⚡️ Lighthouse report for the deploy preview of this PR
|
github-actionsbot commentedJan 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Size Change: +1.84 kB (0%) Total Size: 929 kB
ℹ️View Unchanged
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
CLA SignedSigned Facebook CLA domain: i18nRelated to the i18n system pr: new featureThis PR adds a new API or behavior.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Motivation
Translating through the
i18nfolder is nice for i18n SaaS integrations (Crowdin)But it is not ideal for simpler needs based on Git, as it requires to explain the i18n folder structure convention.
To make i18n simpler to adopt, let's add support for localized file extensions to all our core content plugins
./docs/myDoc.fr.md./blog/myBlog.fr.md./src/pages/myPage.fr.tsxThis kind of convention is already used by other documentation frameworks:
Note, we also want to support this for metadata files:
_category_.fr.ymlauthors.fr.ymlNote, the
editUrlandeditLocalizedFilesoptions should rather work as expected tooTest Plan
Unit tests + dogfood
Test links
https://deploy-preview-9700--docusaurus-2.netlify.app/
Local: