Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

updated deprecated rules#11622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iansu merged 1 commit intofacebook:mainfromwisammechano:patch-1
Jan 12, 2022
Merged

updated deprecated rules#11622

iansu merged 1 commit intofacebook:mainfromwisammechano:patch-1
Jan 12, 2022

Conversation

@wisammechano
Copy link
Contributor

Recent eslint update deprecated rulesno-native-reassign &no-negated-in-lhs in favor offno-global-assign &no-unsafe-negation.

I've tested this working by turning off these 2 rules in package.json eslint config, and adding the updated rules instead. It stopped the deprecation warning.

Recent eslint update deprecated rules `no-native-reassign` & `no-negated-in-lhs` in favor off `no-global-assign` & `no-unsafe-negation`.
@facebook-github-bot
Copy link

Hi@wisammechano!

Thank you for your pull request and welcome to our community.

Action Required

In order to mergeany pull request (code, docs, etc.), werequire contributors to sign ourContributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign athttps://code.facebook.com/cla.If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, thepull request will be tagged withCLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us atcla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@raixraix added this to the5.0.1 milestoneDec 18, 2021
@iansuiansu merged commit63ae6dd intofacebook:mainJan 12, 2022
@iansu
Copy link
Contributor

Thanks!

GoetzGoerisch pushed a commit to umati/create-react-app that referenced this pull requestJan 13, 2022
GoetzGoerisch pushed a commit to umati/create-react-app that referenced this pull requestJan 13, 2022
aruniverse pushed a commit to imodeljs/create-react-app that referenced this pull requestSep 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iansuiansuAwaiting requested review from iansu

Assignees

No one assigned

Projects

None yet

Milestone

5.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wisammechano@facebook-github-bot@iansu@raix
[8]ページ先頭
©2009-2025 Movatter.jp