Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
docs: add security.txt#1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:gh-pages
Are you sure you want to change the base?
Conversation
netlifybot commentedJul 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forexpressjscom-preview ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
ctcpip left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't we try to comply withthe spec?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bjohansebas commentedJul 18, 2025
|
UlisesGascon commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
If any reporter requests PGP encryption, we can accommodate them using our personal PGP keys. However, we don’t have a shared/team key at this time.
Personally, I like the idea. It would add an extra step for each report, but many reporters are doing excellent work and I think it’s worth the effort to recognize them publicly. Should we bring this up for discussion in the security working group?
I think English is the best option to simplify report digestion
I am afraid that this is mandatory in the spec (https://www.rfc-editor.org/rfc/rfc9116#name-expires). We don’t expect this information to become stale, but the specification says the Expires field must always be present and recommends that the value be less than a year into the future to avoid staleness. To comply with this requirement, we use one of the following approaches:
We avoid using long-term future dates like the year 2099, since that would technically comply but go against the intent of keeping the file current and accurate. We can do the automation in the future, so we can land this PR soon. |
Uh oh!
There was an error while loading.Please reload this page.
ShubhamOulkar commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Instead of setting an expiration date, I'd prefer to define the
Tracking in discussion is a good idea. My personal opinion, we should not do it in open environment. |
bjohansebas commentedJul 18, 2025
@ShubhamOulkar I don't quite understand this idea.
Yes, please bring the discussion to the security team. This decision would be outside the scope of the documentation team.
I can work on this new script, I enjoy automating things. |
ShubhamOulkar commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We should place the "security.txt" file under the "/.well-known/" path, e.g.,https://example.com/.well-known/security.txt as per RFC8615 of a domain name. Ref:https://www.rfc-editor.org/rfc/rfc9116#name-location-of-the-securitytxt
Its main aim is to define the process of reporting security vulnerabilities. |
Co-authored-by: shubham oulkar <91728992+ShubhamOulkar@users.noreply.github.com>
Co-authored-by: shubham oulkar <91728992+ShubhamOulkar@users.noreply.github.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
bjohansebas commentedDec 14, 2025
I created a script to update the expiration date. For the Acknowledgments field, i created this issue for discussion#2132 |
| # Our security policy | ||
| Policy: https://github.com/expressjs/express/security/policy | ||
| # Expires this policy | ||
| Expires: 2025-12-31T00:00:00Z No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I left this date to verify that the automation works and opens the PR correctly.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ref:#1973
preview:https://deploy-preview-1974--expressjscom-preview.netlify.app/.well-known/security.txt
cc: @expressjs/security-wg