Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add security.txt#1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bjohansebas wants to merge8 commits intogh-pages
base:gh-pages
Choose a base branch
Loading
fromsecurty.txt
Open

docs: add security.txt#1974

bjohansebas wants to merge8 commits intogh-pagesfromsecurty.txt

Conversation

@bjohansebas
Copy link
Member

@bjohansebasbjohansebas commentedJul 16, 2025
edited
Loading

@bjohansebasbjohansebas requested a review froma team as acode ownerJuly 16, 2025 17:00
@netlify
Copy link

netlifybot commentedJul 16, 2025
edited
Loading

Deploy Preview forexpressjscom-preview ready!

NameLink
🔨 Latest commitf6e73f9
🔍 Latest deploy loghttps://app.netlify.com/projects/expressjscom-preview/deploys/693ef8bdbfe4dd0008aec0e9
😎 Deploy Previewhttps://deploy-preview-1974--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link
Member

@ctcpipctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shouldn't we try to comply withthe spec?

@bjohansebas
Copy link
MemberAuthor

  • encryption: as far as I know, we don't have a PGP key for emails, so it's not needed unless we want to start using it.
  • Acknowledgments: we don't have that page, do we want it?
  • Canonical: this is not necessary, this is the source of the security.txt file.
  • expire: we don't need it, because why would we set an expiration date on this content? We will always keep it updated, even though the specification says it's required.
  • hiring: we don't need it, we are not hiring, but we are always looking for collaborators
  • Preferred-Languages: if not specified, it defaults to English. Do we want to add more languages? We are a diverse group in terms of languages.

@UlisesGascon
Copy link
Member

UlisesGascon commentedJul 18, 2025
edited
Loading

encryption: as far as I know, we don't have a PGP key for emails, so it's not needed unless we want to start using it.

If any reporter requests PGP encryption, we can accommodate them using our personal PGP keys. However, we don’t have a shared/team key at this time.

Acknowledgments: we don't have that page, do we want it?

Personally, I like the idea. It would add an extra step for each report, but many reporters are doing excellent work and I think it’s worth the effort to recognize them publicly. Should we bring this up for discussion in the security working group?

Preferred-Languages: if not specified, it defaults to English. Do we want to add more languages? We are a diverse group in terms of languages.

I think English is the best option to simplify report digestion

expire: we don't need it, because why would we set an expiration date on this content? We will always keep it updated, even though the specification says it's required.

I am afraid that this is mandatory in the spec (https://www.rfc-editor.org/rfc/rfc9116#name-expires). We don’t expect this information to become stale, but the specification says the Expires field must always be present and recommends that the value be less than a year into the future to avoid staleness.

To comply with this requirement, we use one of the following approaches:

  • Option A: Set a fixed date like the end of each calendar year (for example, December 31, 2025) and use a reminder system to update it annually.
  • Option B (preferred): Automatically generate this field with a rolling expiration, such as today plus 180 days, so it always stays within the recommended freshness window.

We avoid using long-term future dates like the year 2099, since that would technically comply but go against the intent of keeping the file current and accurate.

We can do the automation in the future, so we can land this PR soon.

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commentedJul 18, 2025
edited
Loading

  • expire: we don't need it, because why would we set an expiration date on this content? We will always keep it updated, even though the specification says it's required.

Instead of setting an expiration date, I'd prefer to define thescope of the security.txt file for specific domains.

*Acknowledgments: we don't have that page, do we want it?

Tracking in discussion is a good idea. My personal opinion, we should not do it in open environment.

@bjohansebas
Copy link
MemberAuthor

Instead of setting an expiration date, I'd prefer to define the scope of the security.txt file for specific domains.

@ShubhamOulkar I don't quite understand this idea.

Personally, I like the idea. It would add an extra step for each report, but many reporters are doing excellent work and I think it’s worth the effort to recognize them publicly. Should we bring this up for discussion in the security working group?

Yes, please bring the discussion to the security team. This decision would be outside the scope of the documentation team.

Option B (preferred): Automatically generate this field with a rolling expiration, such as today plus 180 days, so it always stays within the recommended freshness window.

I can work on this new script, I enjoy automating things.

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commentedJul 18, 2025
edited
Loading

We should place the "security.txt" file under the "/.well-known/" path, e.g.,https://example.com/.well-known/security.txt as per RFC8615 of a domain name. Ref:https://www.rfc-editor.org/rfc/rfc9116#name-location-of-the-securitytxt

I don't quite understand this idea.

Its main aim is to define the process of reporting security vulnerabilities.
https://www.rfc-editor.org/rfc/rfc9116#name-scope-of-the-file

bjohansebasand others added4 commitsDecember 14, 2025 11:34
Co-authored-by: shubham oulkar <91728992+ShubhamOulkar@users.noreply.github.com>
Co-authored-by: shubham oulkar <91728992+ShubhamOulkar@users.noreply.github.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@github-actions

This comment was marked as off-topic.

@bjohansebas
Copy link
MemberAuthor

I created a script to update the expiration date.

For the Acknowledgments field, i created this issue for discussion#2132

@bjohansebasbjohansebas self-assigned thisDec 14, 2025
# Our security policy
Policy: https://github.com/expressjs/express/security/policy
# Expires this policy
Expires: 2025-12-31T00:00:00Z No newline at end of file
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left this date to verify that the automation works and opens the PR correctly.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ctcpipctcpipAwaiting requested review from ctcpip

@ShubhamOulkarShubhamOulkarAwaiting requested review from ShubhamOulkar

@UlisesGasconUlisesGasconAwaiting requested review from UlisesGascon

1 more reviewer

@efekrsklefekrsklefekrskl approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@bjohansebasbjohansebas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjohansebas@UlisesGascon@ShubhamOulkar@efekrskl@ctcpip

[8]ページ先頭

©2009-2025 Movatter.jp