- Notifications
You must be signed in to change notification settings - Fork1.8k
Refactor style.css#1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:gh-pages
Are you sure you want to change the base?
Refactor style.css#1786
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedFeb 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forexpressjscom-preview ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
jonchurch commentedFeb 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What maintainability issues are you running into currently? That the styles file is 1200 lines long? I see the value in organizing styles, but right now, this approach increases the number of HTTP requests without a build step to merge them (jekyll supports scss), which could negatively impact performance. We go from 1 request to 9. Also, from a developer experience perspective, having to jump between multiple small files can sometimes make it harder to track down and modify styles efficiently. A single, well-structured file can often be easier to work with than several separate ones. Some of these files, like The goal should be improving maintainability without making performance worse or adding manual overhead. What do you think? |
It's a very large and somewhat disorganized file, so if we can separate it into a few files and organize it better, that would be great.
I like both options, I will apply them. Thanks for the suggestion! |
ShubhamOulkar commentedFeb 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Please don't add files in header that are not present in repo. express.com showing same error in the console.
Are you planning to add light-theme? I dont think it is needed. As@jonchurch said don't increase network calls. Just need to remove redundant css selectors. I can see that light mode text colors and background colors are not broken in this pr but I dont find light-theme.css file in pr. |
I forgot to remove that request from the head, sorry about that. I've deleted it in this pr. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
} | ||
} | ||
/* ----------------- Blog --------------------- */ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
} | ||
} | ||
/* ----------------- Side Menu --------------------- */ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
I'm trying not to delete or modify any CSS styles, as these are style changes of code. |
Ok, do it without changes. I want to remind you that if we are rewriting css then we don't need so many css files. Only variable.css and style.css more than enough. It is up to you. Please do it earlier. I am waiting this pr to merge. |
This is not a priority, and it shouldn't be a dependency for creating PRs. I'm going to put it in draft for now, and I'll come back to it later. |
Uh oh!
There was an error while loading.Please reload this page.
To make it more maintainable and to better edit our styles, I am separating the styles into multiple files depending on their purpose.
close:#1751