Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork21.8k
Added HTTP exceptions, compression, helmet, and CORS integration#6846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
…g middleware and add bun.lock to .gitignore file
Review the following changes in direct dependencies. Learn more aboutSocket for GitHub.
|
ken-ten commentedOct 18, 2025
i don't think this is even relevant, is there even any feature request for this |
bjohansebas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your contribution. A few things: we don’t accept changes to the code style.
It seems this PR is trying to do two things — adding compression, helmet, and CORS to the Express core. I recommend opening a discussion about this instead of doing it all at once in a PR.
The second thing is addingHttpException. What’s the intention behind this? I’d suggest opening a discussion for that as well, since I don’t really understand the reason why you’d want to add it.
Added http exceptions for better error handling created error handling middleware and add bun.lock to .gitignore file