Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork21.8k
test: enhance req.is() tests with additional cases#6703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
| @@ -1,7 +1,8 @@ | |||
| 'use strict' | |||
| varexpress=require('..') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| varexpress=require('..') | |
| constexpress=require('..') |
| 'use strict' | ||
| varexpress=require('..') | ||
| varrequest=require('supertest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| varrequest=require('supertest') | |
| constrequest=require('supertest') |
| varexpress=require('..') | ||
| varrequest=require('supertest') | ||
| varafter=require('after') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| varafter=require('after') | |
| constafter=require('after') |
// in modern JS is better to use const instead of var!
hamidrezaghavami left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
your code was so structured, I mainly review it for learning purposes, well done!
Uh oh!
There was an error while loading.Please reload this page.
Basically, we support an array as an argument for req.is. This hasn’t been documented, and we should document it on the website.
Ref:
express/lib/request.js
Line 260 in8f21493