Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

- a little hack to enable custom request decryption#86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vietanh85 wants to merge6 commits intoexpressjs:master
base:master
Choose a base branch
Loading
fromvietanh85:master

Conversation

@vietanh85
Copy link

  • Sometime we need to encrypt response and request from client to server to ensure security

@vietanh85vietanh85 changed the title- a little hack to enable custom request description- a little hack to enable custom request decryptionMar 25, 2015
@dougwilson
Copy link
Contributor

Makes sense. Can the decryption be done as a stream instead of a sync decryption?

@vietanh85
Copy link
Author

Since, we are using raw-body to convert request stream to a buffer. In addition, I've learned that, there is no way to modify a readable stream in nodejs. So I think we cannot decrypt a stream.

@dougwilson
Copy link
Contributor

I'm talking about changing the interface here to take a TransformStream, rather than do it prior to calling this module.

@dougwilson
Copy link
Contributor

Ok, sorry we misunderstood. Theuser needs to pass in a TransformStream as the decrypt argument. What we have here is still the same DoS vector.

@dougwilson
Copy link
Contributor

And if possible, please add tests and make sure decryption occurs after inflation.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@Fatih86Fatih86Fatih86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dougwilsondougwilson

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vietanh85@dougwilson@Fatih86

[8]ページ先頭

©2009-2025 Movatter.jp