Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork753
- a little hack to enable custom request decryption#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vietanh85 commentedMar 25, 2015
- Sometime we need to encrypt response and request from client to server to ensure security
dougwilson commentedMar 25, 2015
Makes sense. Can the decryption be done as a stream instead of a sync decryption? |
vietanh85 commentedMar 26, 2015
Since, we are using raw-body to convert request stream to a buffer. In addition, I've learned that, there is no way to modify a readable stream in nodejs. So I think we cannot decrypt a stream. |
dougwilson commentedMar 26, 2015
I'm talking about changing the interface here to take a TransformStream, rather than do it prior to calling this module. |
dougwilson commentedMar 26, 2015
Ok, sorry we misunderstood. Theuser needs to pass in a TransformStream as the decrypt argument. What we have here is still the same DoS vector. |
dougwilson commentedMar 26, 2015
And if possible, please add tests and make sure decryption occurs after inflation. |
0ad1d88 to2a2f471Compare