Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

perf(urlencoded): move empty-body guard to avoid extra function closure#647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Phillip9587 wants to merge1 commit intoexpressjs:master
base:master
Choose a base branch
Loading
fromPhillip9587:urlencoded-remove-extra-closure

Conversation

@Phillip9587
Copy link
Member

Inlines the empty-body check into the parser returned bycreateQueryParser, removing the extra wrapper function. The behavior is unchanged but we get a minor perf/alloc win by not creating a extra closure.

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR optimizes the URL-encoded body parsing by eliminating an extra function closure and moving the empty-body check directly into the parser function. The change improves performance by removing an unnecessary wrapper function while maintaining identical behavior.

  • Moves empty-body guard from wrapper function to main parser function
  • Eliminates extra function closure creation
  • Changesvar toconst for the parser assignment

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

@Phillip9587Phillip9587 requested a review froma teamOctober 27, 2025 20:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@UlisesGasconUlisesGasconAwaiting requested review from UlisesGascon

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Phillip9587

[8]ページ先頭

©2009-2025 Movatter.jp